1115583 - [SMS] URLs with numbers are recognized as phone numbers

Status: RESOLVED DUPLICATE of bug 1091511

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Brian Birtles (:birtles)]

Attachment: Screenshot of problem (with some digits blurred later)

See the attached screenshot. I received a message from my carrier asking me to fill out a survey with the following text:

  [auより]店舗ｱﾝｹｰﾄにご協力をお願いいたしますhttp://au-e.jp/?p=3340XXXXXXXXXXXXX

(I've replaced most of the digits here with X and blurred them in the screenshot in case that number is tied to my account some how.)

Expected result:
The URL is recognized and is clickable.

Actual result:
The number in the URL is recognized as a phone number and only it is clickable.

Comment 1

[Brian Birtles (:birtles)]

I forgot to add that this is on an Fx0 device, i.e. Firefox 2.0.

Comment 2

[Brian Birtles (:birtles)]

Looks like we are expecting URLs to be at the start of a string / after whitespace:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/link_helper.js#L113

Comment 3

[Brian Birtles (:birtles)]

We could adjust safeStart to match non-latin text:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/link_helper.js#L61

Comment 4

[Julien Wajsberg [:julienw]]

mmm yeah, the real issue is that we don't match URL after a full-width character. We have another bug about this but we didn't find that it was a serious enough issue to fix it.

But now that I see it's a real issue in the real world, I think we can increase the priority of that issue, so thanks a lot for reporting :)