1115649 - Differentiate concept of Panel and Dialog in Keyboard Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

In bug 1102831, the term "panel" (both as a concept and in the actual codes) is used interchangeably for a panel and a dialog.

As in Settings app, a dialog is of a more limited use: it can only exit to its caller [1] and cannot transition to further panels (it can show further dialogs, though, in a stacked sense).

So, let's codify the concept.

[1] (through onsubmit or onreset, although I got a bit lazy in bug 1102831 and only implemented onsubmit which is used even when user clicks the "X").

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Alrrright Tim, please check the patch.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Waiting for try-run after tree opened and rebasing: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dd61f1fe2cd6

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/d71bd8390d4dfcfaac06c903b49b4774ab12b866 . Gij-7 had failures that were also present in other people's tries.