1115661 - remove unused code from talos: results.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

results.py has code to run standalone:
http://hg.mozilla.org/build/talos/file/tip/talos/results.py#l521

In fact, this is a feature we haven't used at all, and we could remove this from the source code so this is just a library.

Comment 1

[Ankit Goyal]

Attachment: Removed

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8541692 [details] [diff] [review]
Removed

Review of attachment 8541692 [details] [diff] [review]:
-----------------------------------------------------------------

very nice!  Can you remove unused imports as well.  I know optparse is one, maybe it is the only other one.

One last thing, if you could set a comment on your patch to be:
Bug 1115661 - remove unused code from talos: results.py. r=jmaher

Also setup hg to have your username and make sure you have that set on your patch.

Comment 3

[Ankit Goyal]

Attachment: Bug 1115661 - remove unused code from talos: results.py. r=jmaher

Comment 4

[Ankit Goyal]

Attachment: Bug 1115661 - remove unused code from talos: results.py. r=jmaher

Also removed `main` reference from `__all__`

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8542020 [details] [diff] [review]
Bug 1115661 - remove unused code from talos: results.py. r=jmaher

Review of attachment 8542020 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  This is nice and clean :)

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/53ba530a1097

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks Ankit for getting this completed!  I know you had expressed interest in fixing bug 776947, do let me know if that is problematic or you have other interests.