1115703 - onicecandidate event must set candidate.sdpMid

Status: RESOLVED DUPLICATE of bug 1192813

(Core :: WebRTC, defect, P3)

Description

[Iñaki Baz Castillo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36

Steps to reproduce:

Create a mozRTCPeerConnection and log the data provided by onicecandidate event.


Actual results:

The candidate.sdpMid field has an empty string as value.


Expected results:

According to the WebRTC draft the event.candidate object must include:

-------------------
interface RTCIceCandidate {
                attribute DOMString?      candidate;
                attribute DOMString?      sdpMid;
                attribute unsigned short? sdpMLineIndex;
    serializer = {attribute};
};


sdpMid of type DOMString, , nullable
If present, this contains the identifier of the "media stream identification" as defined in [RFC3388] for the m-line this candidate is associated with.
------------------

Firefox (at least version Nightly 37) does include a "a:mid" attribute in every m= section of the SDP:

-----------------
m=audio 9 RTP/SAVPF 109 9 0 8
c=IN IP4 0.0.0.0
a=mid:sdparta_0
-----------------

and thus it should set the candidate.sdpMid field with "sdparta_0".

Comment 1

[Maire Reavy [:mreavy]]

Bryon?  If this is right, can you confirm and set pri/rank/Blocking?  Thanks!

Comment 2

[Byron Campen [:bwc]]

Yes, this is right. While it is a spec compliance problem, it isn't causing interop problems because the same spec requires addIceCandidate to handle our (incorrect) behavior. Still would be good to get this fixed.

Comment 3

[Igor]

The same issue is on OS X 39.0.3.
Are you going to fix this or not?

Comment 4

[Byron Campen [:bwc]]

When we can fit it in, yes.

Comment 5

[Nils Ohlmeier [:drno]]

Looks to me like this got fixed at some point. I see in Fx 46 ICE candidates have Mid attributes set.

Comment 6

[Nils Ohlmeier [:drno]]

For the record: got fixed in 39 through bug 1192813.