1115727 - Open Sans font on sendto.mozilla.org does not render well characters with diacritics

Status: RESOLVED FIXED

(Websites :: donate.mozilla.org, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I don't know, if this page is in production (as I've found a link only in todays fundraising.mozilla.org blog post, resp. linked wiki), but on https://sendto.mozilla.org/page/content/paypal-donate-czk/, the Open Sans does not render well characters with diacritics (e.g. here for Czech see the h4 headline or the radio labels).

I think, it could be caused by the Open Sans Light font as Bug 776905 seems pretty similar.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Jennifer, does this fall into your bucket of projects?

Comment 2

[Jennifer Bertsch [:jbertsch]]

Adding our Foundation friends who own sendto (aka Andrea Wood)

Comment 3

[Andrea Wood [:andreawood]]

Thanks all, copying Ali, who helped translate and build those pages.

Comment 4

[Ali Al Dallal [:alicoding]]

Thanks guys! I didn't really actually see the problem when implemented this page or didn't really know what was the right character set for the language. Obvious this is no longer in production, but I made a reference for myself for the future project in regard to Open Sans where we should be using the full character sets or have to make sure it is covered for all locales we support.

I'm closing this ticket now. Thanks!

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

So this won't be fixed (than WONTFIX?)?

In fact the site is in production and reachable e.g. from tabzilla (the complete URL is https://sendto.mozilla.org/page/content/paypal-donate-czk/?source=mozillaorg_tabzillaTXT&ref=EOYFR2014&utm_campaign=EOYFR2014&utm_source=mozilla.org&utm_medium=referral&utm_content=PPcurrency_CZK&icn=tabz ).

Comment 6

[Scott [:thecount] Downe]

I think this is worth keeping open.

The page is in production, but we're not putting a campaign behind it right now.

However, I'm not sure how to fix it. I need a better understanding as to why it's not rending well.

Ali, can you elaborate more as to what you mean by "using a full character set"?

Comment 7

[Ali Al Dallal [:alicoding]]

Sorry :MikkCZ I didn't know that this site was reachable still and I just saw the same when I clicked on Tabzilla.

:thecount so when we import the font from Google Font we need to make sure we select all character sets

step 2. Choose the character sets you want:



Question for you :MikkCZ, can you point at or screenshot the problem on that page for the language which is currently is the problem? I'm trying to see when I change the font to the full set and not sure what I'm suppose to see here since they look the same to me before and after.

Comment 8

[Ali Al Dallal [:alicoding]]

So I'm wondering if this seem to be okay for you? https://dl.dropboxusercontent.com/spa/i4jwtlgrlk5yjaa/vg1sf8a6.png

Comment 9

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot

Thank you for reopening. In fact I realized the page is reachable in Tabzilla also after reporting this bug. I've found it mentioned only in a blog post before.

Attaching the screenshot with red underlined wrong rendered characters.

The screenshot from you :alicoding looks good. The font seems bolder for me, but that's maybe platform dependent? Only regression is broken lock (i.fa.fa-lock::before).

Comment 10

[Ali Al Dallal [:alicoding]]

So one thing I'm still trying to find out which is the differences between yours and my screenshot which is currently look identical except the font-weight which was my mistake since I've set that myself. Do you happen to have anyway that you can show me what is the right way that those underpants characters should be?

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot 2 ("č" vs "c"

On my screenshot you can see that the underlined chars are from some secondary font - just compare "č" in "částku" and "c" in "chcete". Their curving is different - "č" is more closed on the right.

Comment 12

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot 2 ("č" vs "c")

On my screenshot you can see that the underlined chars are from some secondary font - just compare "č" in "částku" and "c" in "chcete". Their curving is different - "č" is more closed on the right.

Comment 13

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

(In reply to Ali Al Dallal [:alicoding] from comment #10)
> So one thing I'm still trying to find out which is the differences between
> yours and my screenshot which is currently look identical except the
> font-weight which was my mistake since I've set that myself. Do you happen
> to have anyway that you can show me what is the right way that those
> underpants characters should be?

They are not bolder,they are different fonts. You are using on this site a version of Open Sans that does not include Czech letters, the browser is using another font available on the OS to replace the letters missing in Open Sans, otherwise, there would be missing letters in the sentence. Replace the version of Open Sans you use on the site by one that includes more charsets (= letters that exist in other languages). Basically,just use the same files for fonts as what we have on www.mozilla.org.

Comment 14

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

"Fundraising" is comming, but this bug is still not resolved. Unfortunately I haven't found any appropriate bug, which would be blocked by this.

Comment 15

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Created PR https://github.com/mozilla/donate.mozilla.org/pull/428.

Comment 16

[Erika Drushka]

Closing this as I believe the issue was resolved on Github.

Comment 17

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Does not seems to be fixed on https://sendto.mozilla.org/page/content/paypal-donate-czk/ nor Pontoon live preview. Is that patch in production?

Comment 18

[Scott [:thecount] Downe]

We're transitioning away from the sendto.mozilla.org page for donations, and moving it to donate.mozilla.org, which is our current production, with most links pointing to donate.mozilla.org.

A few are still pointing to sendto while we sort that out.

So, fixes are here: https://donate.mozilla.org/cs/paypal-donate/?currency=czk and here: https://donate.mozilla.org/cs/?currency=czk

Comment 19

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you. I was going through the link in Tabzilla, where is still sendto.mozilla.org address, but marking as verified, as it truly works on donate.mozilla.org.

Comment 20

[Scott [:thecount] Downe]

:D

Comment 21

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Have to REOPEN, as found a case, when the fix does not work. How to reproduce?

1) Have Czech Firefox or browser preferring Czech website versions.
2) Load https://donate.mozilla.org/ (without /cs/ specified).
3) See the fonts are broken.

After reloading the website (with https://donate.mozilla.org/cs/), the fonts are OK again, but going to https://donate.mozilla.org/ breaks the again. What's interesting, that it's not necessary to clear the browsers cache nor use "hard" reload with Ctrl+F5.

Comment 22

[Scott [:thecount] Downe]

Looking into it.

Comment 23

[Scott [:thecount] Downe]

We're moving the redirect to a server side redirect, which would fix this.

I'll keep this open and update it when the server side redirect is done.

Comment 24

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Works now.