1115738 - [Spam] Transform the "View IP" column content into a button in the "Author" column

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jean-Yves Perrier [:teoli]]

What did you do?
================
1. Go to Revision Dashboard
2. Click on first entry to see the diff

What happened?
==============
See image

What should have happened?
==========================
Like before (View IP as a new column, but diff spanning to it)

Is there anything else we should know?
======================================

Comment 1

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2014-12-26 at 19.53.52.png

The new View IP pushes the diff on the side (instead of below)

Comment 2

[Luke Crouch [:groovecoder]]

Filed https://github.com/mozilla/kuma/pull/2973 but I'm not sure I did the right thing with the stylus/css/grid layout.

Comment 3

[Jean-Yves Perrier [:teoli]]

Just got this alternative idea (for presentation):

What about making View IP a button under the Author column (displayed at the same time as the button under the Title column ?
(We could also add a Ban button there, for people with ban privileges).

Comment 4

[Luke Crouch [:groovecoder]]

That sounds good to me. Should we change this bug into that request, or file a new bug?

Comment 5

[Jean-Yves Perrier [:teoli]]

I would say: change this bug into that request.

Comment 6

[Luke Crouch [:groovecoder]]

Filed https://github.com/mozilla/kuma/pull/2978 for this.

Comment 7

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/a4342590faf4d35461aec9918758bc67f8bb5eae
fix bug 1115738 - move IP to author column in dashboard

https://github.com/mozilla/kuma/commit/b5d24c246c90c361f2c91639d07f8e9e74330df8
Merge pull request #2978 from groovecoder/move-ip-to-author-column-1115738

fix bug 1115738 - move IP to author column in dashboard

Comment 8

[Florian Scholz (Open Web Docs)]

Attachment: rev-dash-diffs.png

Now the diff is weird for me...

Comment 9

[Luke Crouch [:groovecoder]]

Grr ... I'm on it ... this is what I get for doing CSS code. Sorry.

Comment 10

[Luke Crouch [:groovecoder]]

https://github.com/mozilla/kuma/pull/2988

Comment 11

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/51eee42672c047232a55edbcf365ddb946c0a7d7
Fix bug 1115738 again: Select only outer cells

https://github.com/mozilla/kuma/commit/919ce5f65fd7c05e0d65c1d7511e18a25b62d29e
Merge pull request #2989 from openjck/bug-1115738-style-outer-table-only

Fix bug 1115738 again: Select only outer cells

Comment 12

[Luke Crouch [:groovecoder]]

Okay, this is live on prod. Sorry for the screw-up. REOPEN if there's something else.

Comment 13

[Florian Scholz (Open Web Docs)]

Looks great. Thanks for the quick fix!