Closed
Bug 1115740
Opened 9 years ago
Closed 3 years ago
Don't bailout in an int32 unbox for double type that fits in int32
Categories
(Core :: JavaScript Engine: JIT, defect, P5)
Tracking
()
RESOLVED
DUPLICATE
of bug 1686702
People
(Reporter: h4writer, Unassigned)
References
(Blocks 1 open bug)
Details
int32 -> MToDouble -> MBox -> MUnbox<int32> bails currently, which is unfortunate. We should support this.
|
Reporter | |
Comment 1•9 years ago
|
||
Improves mandreel from 2738 to 14118 again after applying bug 1114981. (before patch it is 28529, so not fully fixed yet)
|
||
Comment 2•3 years ago
|
||
Is this bug still relevant and free to work on? I thought about adding a code path to CodeGenerator::visitUnbox in the individual js/src/jit/X/CodeGenerator-X.cpp files. Alternatively, masm.fallibleUnboxInt32 could be upgraded with more logic.
One minor note: js/src/jit/mips32/CodeGenerator-mips32.cpp doesn't seem to implement infallible unboxing of int32?
|
||
Comment 3•3 years ago
|
||
Iain, is this issue fixed through the changes from bug 1686702?
Flags: needinfo?(iireland)
|
||
Comment 4•3 years ago
|
||
Yeah, I think the changes to MUnbox::foldsTo in bug 1686702 cover this.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(iireland)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•