Closed Bug 1115799 Opened 6 years ago Closed 2 years ago

[Browser] Check the menu window to verify that the Add to Homescreen option no longer exists after adding a bookmark to the homescreen

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: nhirata, Unassigned)

Details

Attachments

(1 file)

Naoki should we review this pull?

If yes can you ask the team for reviews
QA Whiteboard: [fxosqa-auto-backlog+]
Flags: needinfo?(nhirata.bugzilla)
yes please.  Is there an alias for team reviews?  Or do I just ask for feedback from specific people?
Flags: needinfo?(nhirata.bugzilla)
Flags: needinfo?(florin.strugariu)
You ask specific people from the team.
Flags: needinfo?(florin.strugariu)
Attachment #8541799 - Flags: review?(viorela.ioia)
Attachment #8541799 - Flags: review?(jlorenzo)
Comment on attachment 8541799 [details] [review]
27023

This is a first good try which is working on my device. The major issue I see here is that is_add_to_home_button_not_in_dialog returns None which makes the assertion using it useless.

In other words, this can lead us to a false positive.
Attachment #8541799 - Flags: review?(jlorenzo) → review-
Comment on attachment 8541799 [details] [review]
27023

Comments in the PR.
Attachment #8541799 - Flags: review?(viorela.ioia) → review-
Hi I see in the status is new and it's assigned to nobody, Can I get this one?
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.