Closed Bug 1115910 Opened 9 years ago Closed 9 years ago

remove mozilla::pkix's nullptr polyfill

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

no-more-nullptr-polyfill.patch
1005 bytes, patch
keeler
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1114703 +++

Once GCC 4.6 becomes the minimum GCC version, we can remove mozilla::pkix's nullptr.h
Assignee: nobody → brian
Status: NEW → ASSIGNED

        Attachment #8548036 -
        Flags: review?(dkeeler)

    
    

    
  
Comment on attachment 8548036 [details] [diff] [review]
no-more-nullptr-polyfill.patch

Review of attachment 8548036 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this patch depends on another that hasn't been landed yet (stdkeywords.h doesn't exist yet in mozilla-central, as far as I can tell), but I agree this is a correct change to make, regardless of what file it happens in.

        Attachment #8548036 -
        Flags: review?(dkeeler) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/081ec95c0933

Thanks for the quick review!
Summary: remove mozilla::pkix's nullptr.h → remove mozilla::pkix's nullptr polyfill
Target Milestone: --- → mozilla38

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/081ec95c0933
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.