1116009 - Icon to add search engine looks very out of place

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot of icon in search field

I'm running the latest aurora and when I load any bugzilla page there's a green + icon on the browser search field that looks very out of place. Clicking on it shows a menu. See screenshots.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot of menu upon clicking icon

Also this is on OS X 10.6.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Seeing this on OS X 10.9.5 as well, latest aurora desktop build.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

[Tracking Requested - why for this release]:

See screenshot, the icon looks very wrong and is very obvious to the user.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Can you elaborate on "very wrong"?

Apart from the increased contrast from the dark Dev Edition theme, this is how this feature was intended to look (see bug 1106432).

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #4)
> Can you elaborate on "very wrong"?

Unfortunately I don't have the right vocabulary to elaborate much. The best I can say is that the color contrast and the sharp edges of the green plus make it look like the plus is "floating" on top of the search bar rather than being attached to the magnifying glass.

> Apart from the increased contrast from the dark Dev Edition theme, this is
> how this feature was intended to look (see bug 1106432).

Man. If it's intended to look this way I guess that's fine, but we should try to make sure these things look good in the dark dev edition theme. This is the second time (see bug 1098401 for the first) I've seen new icons appear that just look wrong in Aurora but are "by design".

Comment 6

[Botond Ballo [:botond]]

To me, the reason it looks out of place is that the icon design does not make it immediately clear that the plus sign is part of / an addition to the search icon; visually, it looks "on top"/"overlaid" rather than "part of" the underlying icon.

It also wasn't clear to me what the purpose of the icon was (in particular, that it was connected to the current page I was viewing) until I looked at the bug you linked to.

Comment 7

[Tim Nguyen :ntim]

We can reduce the opacity for DevEdition I guess.

Comment 8

[Dave Townsend [:mossop]]

Stephen, can you make a call on this

Comment 9

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 10

[Mike Kaply [:mkaply]]

This looks much better in our current theming.

Marking as fixed.