Closed Bug 1116038 Opened 9 years ago Closed 9 years ago

[e10s] Disabled select option not disabled

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
e10s m7+ ---
firefox41 --- fixed

People

(Reporter: freaktechnik, Assigned: enndeakin)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

test case
123 bytes, text/html
Details
Fix test
5.13 KB, patch
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141228030216

Steps to reproduce:

 - Open "data:text/html,<select><option>1</option><option disabled>2</option></select>" in a new tab
 - Try to select the second option


Actual results:

The second option is selectable and not greyed out. Also the first options (which is gets selected by default) has a dot infront of it.


Expected results:

Second option should not be selectable and appear disabled.
Attached file test case — 

    
  

        Attachment #8541972 -
        Attachment filename: file_1116038.txt → test_case.html

        Attachment #8541972 -
        Attachment mime type: text/plain → text/html

    
    

    
  
Oh, and I can't reproduce this bug in the release version on Linux or Windows and the latest Nightly on Windows.

    
  

          tracking-e10s:
          --- → ?
Component: Untriaged → Layout: Form Controls
Product: Firefox → Core

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Summary: Disabled select option not disabled → [e10s] Disabled select option not disabled
Version: 37 Branch → Trunk

    
  
Blocks: fxe10s

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Handle disabled options (obsolete)
        — 
          — Splinter Review
      

    


  
This test applies on top of the ones in 1047713.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

        Attachment #8580019 -
        Flags: review?(felipc)

    
  
Iteration: --- → 39.3 - 30 Mar
Points: --- → 1
Depends on: 1047713
Flags: in-testsuite+
Flags: firefox-backlog+

        Attachment #8580019 -
        Flags: review?(felipc) → review+
Iteration: 39.3 - 30 Mar → 39.2 - 23 Mar
Flags: qe-verify?
Iteration: 39.2 - 23 Mar → 39.3 - 30 Mar

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix test
        — 
          — Splinter Review
      

    


  
I forgot that on Windows, one can navigate disabled items. This patch fixes the test to account for that.

        Attachment #8580019 -
        Attachment is obsolete: true
Iteration: 39.3 - 30 Mar → 40.1 - 13 Apr
Iteration: 40.1 - 13 Apr → 40.2 - 27 Apr

    
  
Blocks: e10s-select

    
    

    
  
Is this ready to land, Enn?
Flags: needinfo?(enndeakin)

    
    

    
  
No, the dependent bug is not fixed.
Flags: needinfo?(enndeakin)

    
    

    
  
Ah. Can you explain why this is blocked by bug 1047713? Is that just the way your patch queue was ordered?
Flags: needinfo?(enndeakin)
Iteration: 40.2 - 27 Apr → 40.3 - 11 May
Iteration: 40.3 - 11 May → 41.1 - May 25

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/407b8e33d727
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

    
    

    
  
Needinfo no longer relevant.
Flags: needinfo?(enndeakin)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: