test_rocketbar_add_collection_save_bookmark.py is skipped on b2g desktop

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: Martijn Wargers (zombie))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
test_rocketbar_add_collection_save_bookmark.py is skipped in the manifest.ini for b2g desktop: skip-if = device == "desktop"
This test is passing just fine on b2g desktop, so I think that line can be removed.

Since the test has "online = true", it means it doesn't run on treeherder anyway, because tests that use external sites don't run on treeherder.
(Assignee)

Comment 1

4 years ago
Created attachment 8542157 [details] [review]
test_rocketbar_add_collection_save_bookmark
Attachment #8542157 - Flags: review?(robert.chira)
Attachment #8542157 - Flags: review?(jlorenzo)
Comment on attachment 8542157 [details] [review]
test_rocketbar_add_collection_save_bookmark

You're right, treeherder actually skips this test even with the line remove. LGTM.
Attachment #8542157 - Flags: review?(jlorenzo) → review+
Comment on attachment 8542157 [details] [review]
test_rocketbar_add_collection_save_bookmark

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/82e7ebc08dcd7f278454ef7983e7dc4f43f3dede
Attachment #8542157 - Flags: review?(robert.chira) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.