talos generateBrowserCommandLine could benefit from a list of extra parameters

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: adusca, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first project][lang=python])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Right now the Talos function generateBrowserCommandLine in utils.py takes a string as extra parameters:
http://hg.mozilla.org/build/talos/file/tip/talos/utils.py#l223

It really should be an array, which means that we could extend the args with more meaningful parameters to the browser.

of course allowing for an array means we should consider the callers.  Ideally you could determine if the type is an array and if so, just extend the parameters, otherwise we can assume it is a string and handle it like we currently do.

to learn more about Talos and how to get started here is a wiki outlining the work:
https://wiki.mozilla.org/Auto-tools/Projects/Talos
(Assignee)

Comment 1

3 years ago
Created attachment 8543537 [details] [diff] [review]
Tentative fix
Attachment #8543537 - Flags: feedback?(jmaher)
(Assignee)

Comment 2

3 years ago
Hi! I'd like to work on this bug. Is the above patch what you had in mind?
(Reporter)

Comment 3

3 years ago
Comment on attachment 8543537 [details] [diff] [review]
Tentative fix

Review of attachment 8543537 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this patch and congratulations on getting your first patch r+!
Attachment #8543537 - Flags: feedback?(jmaher) → review+
(Reporter)

Comment 4

3 years ago
https://hg.mozilla.org/build/talos/rev/c59ed57318c7
(Reporter)

Comment 5

3 years ago
Alice, we have a lot of great projects underway related to automation:
https://wiki.mozilla.org/Auto-tools/Projects/Everything#Project_Table

I would be happy to help you get started on one of those or any specific bug!  

Thanks again for your contribution, this really helps clean up our code and make it more robust.
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Assignee: nobody → alicescarpa
You need to log in before you can comment on or make changes to this bug.