1116422 - urls without the http:// are ignored

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Edmund Wong (:ewong)]

Entering www.foobar.com in cZ (0.99.1) and pressing enter does not 
output it to the chat.  Completely ignores the input.  Even if you type
a whole line that includes www.<anything>.<anything> and it will still
ignore what you entered.

www.foo  and foo.bar are ok.  

http:// needs to be prepended.  Only then will it actually get sent.

Comment 1

[Samuel Sieb]

The problem is with client.checkURLScheme.  There was a change made to lowercase the url scheme.  This throws an exception when the scheme is undefined.

This case happens because replaceColorCodes calls checkURLScheme directly with the result of a regexp.  What case will match the url regexp, but not be a url?  Can we just skip the scheme check as should be handled elsewhere?

Comment 2

[James Ross]

The linkRE will match things like foo:bar so we need to check that foo: is a URL scheme before turning it into a link. This was originally designed with the Mozilla platform's extensibility in mind, so it checks the registered protocol handlers in Components; we could probably just use a whitelist (in the RegExp) these days... but the quick fix is probably to do:

        if (scheme && !client.checkURLScheme(scheme))
            return url;

in replaceColorCodes().

Comment 3

[:Gijs (he/him)]

Attachment: check for undefined scheme,

Per comment 2...

Comment 4

[James Ross]

Comment on attachment 8548549 [details] [diff] [review]
check for undefined scheme,

Review of attachment 8548549 [details] [diff] [review]:
-----------------------------------------------------------------

r=silver, sorry for the delays.

Comment 5

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/872b90216d1f