Closed
Bug 1116422
Opened 9 years ago
Closed 9 years ago
urls without the http:// are ignored
Categories
(Other Applications :: ChatZilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: Gijs)
Details
(Whiteboard: [cz-0.9.92])
Attachments
(1 file)
1.38 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
Entering www.foobar.com in cZ (0.99.1) and pressing enter does not output it to the chat. Completely ignores the input. Even if you type a whole line that includes www.<anything>.<anything> and it will still ignore what you entered. www.foo and foo.bar are ok. http:// needs to be prepended. Only then will it actually get sent.
Comment 1•9 years ago
|
||
The problem is with client.checkURLScheme. There was a change made to lowercase the url scheme. This throws an exception when the scheme is undefined. This case happens because replaceColorCodes calls checkURLScheme directly with the result of a regexp. What case will match the url regexp, but not be a url? Can we just skip the scheme check as should be handled elsewhere?
Comment 2•9 years ago
|
||
The linkRE will match things like foo:bar so we need to check that foo: is a URL scheme before turning it into a link. This was originally designed with the Mozilla platform's extensibility in mind, so it checks the registered protocol handlers in Components; we could probably just use a whitelist (in the RegExp) these days... but the quick fix is probably to do: if (scheme && !client.checkURLScheme(scheme)) return url; in replaceColorCodes().
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 3•9 years ago
|
||
Per comment 2...
Attachment #8548549 -
Flags: review?(bugzilla-mozilla-20000923)
Assignee | ||
Updated•9 years ago
|
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Comment 4•9 years ago
|
||
Comment on attachment 8548549 [details] [diff] [review] check for undefined scheme, Review of attachment 8548549 [details] [diff] [review]: ----------------------------------------------------------------- r=silver, sorry for the delays.
Attachment #8548549 -
Flags: review?(bugzilla-mozilla-20000923) → review+
Assignee | ||
Comment 5•9 years ago
|
||
http://hg.mozilla.org/chatzilla/rev/872b90216d1f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Whiteboard: [cz-0.9.92]
You need to log in
before you can comment on or make changes to this bug.
Description
•