Open Bug 1116426 Opened 9 years ago Updated 2 years ago

[mozdebug] --debugger valgrind assumes memcheck

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Platform:
All
Linux
Type:
defect

Tracking

(Not tracked)

People

(Reporter: glandium, Unassigned)

Details

Using --debugger valgrind passes a few default arguments to valgrind: --leak-check=full --show-possibly-lost=no --smc-check=all-non-file --vex-iropt-register-updates=allregs-at-mem-access.

The first two arguments assume memcheck is the valgrind tool in use, and fail when giving --debugger-args=--tool=somethingelse.

Relatedly, I'd argue --soname-synonyms=somalloc=NONE should be in that list when running Firefox.
Mike, which mozbase tool are you referring to here? I wonder if that is the right component.
The defaults in testing/mozbase/mozdebug/mozdebug/mozdebug.py are used by e.g. mach mochitest-browser.
python/mozbuild/mozbuild/mach_commands.py gets those default args from mozdebug.get_debugger_info. I'd argue the bug is in mozdebug for providing tool-specific defaults.
Thanks Mike. Updating the summary accordingly.
Summary: --debugger valgrind assumes memcheck → [mozdebug] --debugger valgrind assumes memcheck
I suggest keeping this behaviour if you set the --debugger value to |valgrind| or |memcheck|, and then provide reasonable alternatives for |cachegrind| or whichever other tool you're using. The reason being that 99% of the uses will be with Memcheck.

> Relatedly, I'd argue --soname-synonyms=somalloc=NONE should be in that list when running Firefox.

Bug 977067 is about that for |mach valgrind-test| and it turned into a big mess for which I honestly don't remember the details...
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.