Open
Bug 1116533
Opened 10 years ago
Updated 10 years ago
global/header.html.tmpl should load Bugzilla
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Bugzilla
Bugzilla-General
Tracking
()
NEW
People
(Reporter: altlist, Unassigned)
Details
Attachments
(1 file)
337 bytes,
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
The global/header.html.tmpl file should load Bugzilla package. Currently this is done indirectly when loading global/common-links.html.tmpl, yet global/header.html.tmpl also uses it since it is accessing Bugzilla.languages.
Reason I'm reporting it is that I'm overriding global/common-links.html.tmpl and even though I don't need to load Bugzilla, I still had to anyway. Otherwise I get the following error message in my apache log file:
Argument "" isn't numeric in numeric gt (>) at global/header.html.tmpl
I've attached a small patch based on 5.0 branch
Reporter | ||
Updated•10 years ago
|
Attachment #8542618 -
Flags: review?(gerv)
![]() |
||
Comment 1•10 years ago
|
||
Comment on attachment 8542618 [details] [diff] [review]
v1
This probably makes sense, but you should also remove all instances of
[% USE Bugzilla %]
present in all other templates, as it doesn't make sense to waste cycles in USE again and again.
Attachment #8542618 -
Attachment is patch: true
Attachment #8542618 -
Attachment mime type: text/x-patch → text/plain
Attachment #8542618 -
Flags: review?(gerv) → review-
![]() |
||
Updated•10 years ago
|
Severity: minor → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•