Closed Bug 1116537 Opened 5 years ago Closed 5 years ago

Make the history panel work

Categories

(Firefox for iOS :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Unassigned)

References

Details

Attachments

(1 file, 3 obsolete files)

46 bytes, text/x-github-pull-request
wesj
: review+
Details | Review
Hook up the history data source to the panel
Attached file Pull request (obsolete) —
Make the history panel work
Attachment #8542660 - Flags: review?(bnicholson)
Comment on attachment 8542660 [details] [review]
Pull request

Removing r? for now until these are rebased onto the non-Core Data implementation.
Attachment #8542660 - Flags: review?(bnicholson)
Attached file PR (obsolete) —
Attachment #8542660 - Attachment is obsolete: true
Attachment #8545720 - Flags: review?(bnicholson)
Attached file PR (obsolete) —
Updated PR. I also reworked the one history test I have to be a little cleaner in here.
Attachment #8545720 - Attachment is obsolete: true
Attachment #8545720 - Flags: review?(bnicholson)
Attachment #8546844 - Flags: review?(bnicholson)
Comment on attachment 8546844 [details]
PR

Lots of comments in PR, but they're all pretty minor, so this mostly looks good to me.
Attachment #8546844 - Flags: review?(bnicholson) → review-
Attached file Pull request
I'm kinda confused about the r- and the "this looks ok" comment. Re-review if you want....
Attachment #8549930 - Flags: review+
(In reply to Wesley Johnston (:wesj) from comment #6)
> Created attachment 8549930 [details] [review]
> Pull request
> 
> I'm kinda confused about the r- and the "this looks ok" comment. Re-review
> if you want....

Heh, sorry -- I mostly r-'d because of the merge conflicts that were still in the commits, and just wanted to be sure those got fixed and rebased first. This looks fine (with the public accessors changed back to default, if possible).
Attachment #8546844 - Attachment is obsolete: true
We've landed this now in https://bugzilla.mozilla.org/show_bug.cgi?id=1122224
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.