1116537 - Make the history panel work

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

Hook up the history data source to the panel

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

Make the history panel work

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8542660 [details] [review]
Pull request

Removing r? for now until these are rebased onto the non-Core Data implementation.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: PR

Comment 4

[Wesley Johnston (:wesj)]

Attachment: PR

Updated PR. I also reworked the one history test I have to be a little cleaner in here.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8546844 [details]
PR

Lots of comments in PR, but they're all pretty minor, so this mostly looks good to me.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Pull request

I'm kinda confused about the r- and the "this looks ok" comment. Re-review if you want....

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Wesley Johnston (:wesj) from comment #6)
> Created attachment 8549930 [details] [review]
> Pull request
> 
> I'm kinda confused about the r- and the "this looks ok" comment. Re-review
> if you want....

Heh, sorry -- I mostly r-'d because of the merge conflicts that were still in the commits, and just wanted to be sure those got fixed and rebased first. This looks fine (with the public accessors changed back to default, if possible).

Comment 8

[Wesley Johnston (:wesj)]

We've landed this now in https://bugzilla.mozilla.org/show_bug.cgi?id=1122224