Closed Bug 1116641 Opened 5 years ago Closed 5 years ago

Get rid of JNI macros AndroidBridgeUtilities.h

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(2 files)

Add AutoJNIClass to replace previous JNI macros (v1)
1.90 KB, patch
snorp
: review+
Details | Diff | Splinter Review
Change JNI macro usages to use AutoJNIClass (v1)
18.62 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
The JNI macros in widget/android/AndroidBridgeUtilities.h declare a 'jClass' variable in the local scope, which is unexpected and potentially dangerous. We should replace it with something better.
Attachment #8544171 - Flags: review?(snorp)
Attachment #8544172 - Flags: review?(snorp)
Attachment #8544171 - Flags: review?(snorp) → review+
Attachment #8544172 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/0f955b9395c8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.