1116746 - Remove unused statistics from RasterImage

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

There is some truly ancient statistics code in RasterImage that I don't think anyone has used in a very long time. (I checked around with people like bholley.)

It would need to be rewritten as part of the multiple decoders for a single RasterImage refactoring (bug 1079627), but I don't think that's worth it since nobody uses it. Let's just rip it out.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove unused statistics code from RasterImage

Here's the patch.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove unused statistics code from RasterImage

I noticed that this change left |get_header_str| unused. In this new version I remove that too.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove unused statistics code from RasterImage

I take it back; get_header_str is needed until a later patch in my queue removes some other code. Restored it here.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Try job here:

https://tbpl.mozilla.org/?tree=Try&rev=e75646f7143d

Comment 5

[Seth Fowler [:seth] [:s2h]]

Pretty sure those oranges are all from other things in my patch queue. I went ahead and pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/25d6527235ca

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/25d6527235ca