Closed Bug 1116746 Opened 6 years ago Closed 6 years ago

Remove unused statistics from RasterImage

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file, 2 obsolete files)

There is some truly ancient statistics code in RasterImage that I don't think anyone has used in a very long time. (I checked around with people like bholley.)

It would need to be rewritten as part of the multiple decoders for a single RasterImage refactoring (bug 1079627), but I don't think that's worth it since nobody uses it. Let's just rip it out.
Here's the patch.
Attachment #8542942 - Flags: review?(tnikkel)
I noticed that this change left |get_header_str| unused. In this new version I remove that too.
Attachment #8543107 - Flags: review?(tnikkel)
Attachment #8542942 - Attachment is obsolete: true
Attachment #8542942 - Flags: review?(tnikkel)
I take it back; get_header_str is needed until a later patch in my queue removes some other code. Restored it here.
Attachment #8543454 - Flags: review?(tnikkel)
Attachment #8543107 - Attachment is obsolete: true
Attachment #8543107 - Flags: review?(tnikkel)
Attachment #8543454 - Flags: review?(tnikkel) → review+
Pretty sure those oranges are all from other things in my patch queue. I went ahead and pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/25d6527235ca
https://hg.mozilla.org/mozilla-central/rev/25d6527235ca
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.