1116750 - Forcing a repack builder requires to set the "specify script_repo_revision" value

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Massimo Gervasini [:massimo]]

We had a failed repack in Firefox 35.0b8 build 1 (hg timeout)
Usually, when this happens, we re-trigger the job but forcing the builder ended with this error:

KeyError: 'script_repo_revision'
+ releaseTag=

As it is now, to re-start a repack, we need to specify the script_repo_version value manually.

We need to figure out how to do this automatically.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] Set property on the builder

Trying this in staging - set the script_repo_revision on the desktop builder, rather than the scheduler. Mobile l10n already has it set on the builder.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8652148 [details] [diff] [review]
[buildbotcustom] Set property on the builder

The script_repo_revision property doesn't have a useful affect on an Aggregating scheduler, but it does work on the builder for scheduled and rebuilds. I can't find any reason why this was removed in bug 607392.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

To clarify the diff, this sets script_repo_revsion in the set of properties for both firefox and fennec, where previously it was only set for fennec.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Note to self - update https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Tagging_through_Signing#Chunked_repacks when this lands

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8652148 [details] [diff] [review]
[buildbotcustom] Set property on the builder

http://hg.mozilla.org/build/buildbotcustom/rev/3af7c68dfe12

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Rail used this in production today.

Comment 7

[Jordan Lund (:jlund)]

\o/

/me throws away special wand