browser/devtools/webide/test/test_zoom.html leaves a webide window open after it is completed

RESOLVED FIXED in Firefox 37

Status

defect
RESOLVED FIXED
4 years ago
11 months ago

People

(Reporter: jmaher, Assigned: lizzard)

Tracking

unspecified
Firefox 37
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
while testing some fixes locally on a mochitest-chrome test, I noticed that there was a random window sitting around.  Doing some basic sleuthing, I found this to be in the webide directory, and a few test runs yielded test_zoom.html as the culprit:
http://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/test/test_zoom.html

it appears we:
* launch the webide
* zoom, etc.
* close the webide
* launch the webide
* zoom, etc.
* finish

^ notice, we don't appear to have code that closes the webide on the second time.
Thanks Joel, this is a great simple example for me to try out. I will attach my patch in a little bit (am running tests locally just to make sure I am following the correct process).

I am still not sure how to tell what might have been originally calling this or making it fail (It didn't fail when I ran the test)  But maybe that depends on running the full set of tests, or on a particular platform or something. It makes sense that this would probably fix whatever it was, though.
Here you go. I ran the mochitest-chrome tests on browser/devtools/webide/test/ . Nothing failed and no spare WebIDE windows lingered.
Flags: needinfo?(jmaher)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8543436 [details] [diff] [review]
bug-1116802-fix.patch

Review of attachment 8543436 [details] [diff] [review]:
-----------------------------------------------------------------

This is great!  I would be comfortable r+'ing the patch, but in this case lets ask the original test author to review it.  Just in case there is some odd reason why it was written that way.
Attachment #8543436 - Flags: review?(paul)
Attachment #8543436 - Flags: feedback+
Comment on attachment 8543436 [details] [diff] [review]
bug-1116802-fix.patch

Oops :)
Attachment #8543436 - Flags: review?(paul) → review+
(Reporter)

Comment 6

4 years ago
ok, thanks Liz and Paul!
Flags: needinfo?(jmaher)
https://hg.mozilla.org/mozilla-central/rev/c66197902d87
Assignee: nobody → lhenry
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.