If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't PokeGC in SetNewDocument

RESOLVED INCOMPLETE

Status

()

Core
DOM
RESOLVED INCOMPLETE
3 years ago
a year ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Olli said this probably isn't needed.
(Assignee)

Comment 1

3 years ago
Created attachment 8543325 [details] [diff] [review]
Don't PokeGC in SetNewDocument.

This was smaug's idea, so I probably shouldn't have him review. ;)

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d619be17e91
Attachment #8543325 - Flags: review?(peterv)

Comment 2

3 years ago
Comment on attachment 8543325 [details] [diff] [review]
Don't PokeGC in SetNewDocument.

Looks like the GC there is super old code,
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/dom/src/base/nsGlobalWindow.cpp&rev=1.1&root=/cvsroot

Search for ::SetNewDocument
(blame/marking doesn't seem to be able to deal with that file properly)

Comment 3

3 years ago
Comment on attachment 8543325 [details] [diff] [review]
Don't PokeGC in SetNewDocument.

Well, you could then review your own patch if the idea was mine ;)
Attachment #8543325 - Flags: review?(peterv) → review+
(Assignee)

Comment 4

3 years ago
Yeah, I guess.  When I was testing this it looked like any time we were doing a poke for SetNewDocument, we were getting a poke for a bunch of other things so it should be okay in any event.
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca77252e50dd
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f40d0310d5, see bug 1110928 comment 9
(Assignee)

Comment 7

3 years ago
Looks like this wasn't the cause of the orange (though it certainly could have been):
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c40fb1a889b9
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce11eadad118
Backed out for apparently making Android reftests significantly more failure-prone (generally dying mid-run with no usable error).
https://hg.mozilla.org/integration/mozilla-inbound/rev/58767ba4867e

https://treeherder.mozilla.org/logviewer.html#?job_id=5172849&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5172775&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5170636&repo=mozilla-inbound

etc
(Assignee)

Comment 10

a year ago
I'm just going to close this for now. There's probably not a lot of value in tiny GC heuristic adjustments like this.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.