1116821 - Don't PokeGC in SetNewDocument

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

Olli said this probably isn't needed.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Don't PokeGC in SetNewDocument.

This was smaug's idea, so I probably shouldn't have him review. ;)

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d619be17e91

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8543325 [details] [diff] [review]
Don't PokeGC in SetNewDocument.

Looks like the GC there is super old code,
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/dom/src/base/nsGlobalWindow.cpp&rev=1.1&root=/cvsroot

Search for ::SetNewDocument
(blame/marking doesn't seem to be able to deal with that file properly)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8543325 [details] [diff] [review]
Don't PokeGC in SetNewDocument.

Well, you could then review your own patch if the idea was mine ;)

Comment 4

[Andrew McCreight [:mccr8]]

Yeah, I guess.  When I was testing this it looked like any time we were doing a poke for SetNewDocument, we were getting a poke for a bunch of other things so it should be okay in any event.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca77252e50dd

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f40d0310d5, see bug 1110928 comment 9

Comment 7

[Andrew McCreight [:mccr8]]

Looks like this wasn't the cause of the orange (though it certainly could have been):
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c40fb1a889b9

Comment 8

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce11eadad118

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for apparently making Android reftests significantly more failure-prone (generally dying mid-run with no usable error).
https://hg.mozilla.org/integration/mozilla-inbound/rev/58767ba4867e

https://treeherder.mozilla.org/logviewer.html#?job_id=5172849&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5172775&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5170636&repo=mozilla-inbound

etc

Comment 10

[Andrew McCreight [:mccr8]]

I'm just going to close this for now. There's probably not a lot of value in tiny GC heuristic adjustments like this.