Make outgoing use the same auto --rev logic as push

RESOLVED FIXED

Status

Developer Services
Mercurial: firefoxtree
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: gps)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4261] )

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
I like to use "hg outgoing" before I push to make sure I'm pushing the right things and haven't accidentally ended up with stuff in my tree I don't expect. But with firefoxtree installed "hg outgoing" doesn't show the same changesets as "hg push" will push because the latter defaults to "-r ." when pushing to a mozilla repo. outgoing should use the same defaults so I see the right changesets.

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4261]
(Assignee)

Comment 1

3 years ago
This is a reasonable request. I should be able to bang this out real quick.
Assignee: nobody → gps
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8544371 [details] [diff] [review]
firefoxtree: limit heads during outgoing against a Firefox repo ()

firefoxtree already limits considered revisions when interacting with
Firefox trees via `hg push`. This change extends similar functionality
to `hg outgoing` checks.
Attachment #8544371 - Flags: review?(emorley)

Comment 3

3 years ago
Comment on attachment 8544371 [details] [diff] [review]
firefoxtree: limit heads during outgoing against a Firefox repo ()

Review of attachment 8544371 [details] [diff] [review]:
-----------------------------------------------------------------

::: hgext/firefoxtree/__init__.py
@@ +317,5 @@
> +    low-level API used by discovery. Manipulating it could lead to unintended
> +    consequences.
> +    """
> +    tree, uri = resolve_trees_to_uris([dest])[0]
> +    if isfirefoxrepo(repo) and uri:

This differs from the behaviour for |hg push|, in that for push, using '.' isn't conditional on isfirefoxrepo():
https://hg.mozilla.org/hgcustom/version-control-tools/file/0b384be2ce9b/hgext/firefoxtree/__init__.py#l165

Should the behaviour for both be consistent?
Attachment #8544371 - Flags: review?(emorley) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Thanks, gps!
You need to log in before you can comment on or make changes to this bug.