1116872 - java.lang.NullPointerException in MediaPlayerManager onRouteAdded (2014-12-31 Nightly)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The dec 31 nightly build is crashing on startup for me, 100% reproducible on the nexus 4.

Logcat shows this:

12-31 17:19:51.567 D/AndroidRuntime( 6932): Shutting down VM
12-31 17:19:51.567 W/dalvikvm( 6932): threadid=1: thread exiting with uncaught exception (group=0x42070930)
12-31 17:19:51.567 D/dalvikvm(20606): GC_FOR_ALLOC freed 1355K, 13% free 13627K/15488K, paused 51ms, total 51ms
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): java.lang.NullPointerException
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at org.mozilla.gecko.MediaPlayerManager$1.onRouteAdded$64594288(MediaPlayerManager.java:161)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at android.support.v7.media.MediaRouter$GlobalMediaRouter$CallbackHandler.handleMessage(Unknown Source)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at android.os.Handler.dispatchMessage(Handler.java:99)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at android.os.Looper.loop(Looper.java:137)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at android.app.ActivityThread.main(ActivityThread.java:5041)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at java.lang.reflect.Method.invokeNative(Native Method)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at java.lang.reflect.Method.invoke(Method.java:511)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:793)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:560)
12-31 17:19:51.577 E/GeckoCrashHandler( 6932): 	at dalvik.system.NativeStart.main(Native Method)
12-31 17:19:51.627 D/dalvikvm(20606): GC_FOR_ALLOC freed 631K, 13% free 13590K/15488K, paused 48ms, total 48ms

Comment 1

[Kartikaya Gupta (email:[e-mail])]

bp-685ed38a-bc78-4183-88b6-9678c2141231	12/31/14	17:18
bp-7a0c4515-c577-4625-a0d9-181b72141231	12/31/14	11:33
bp-34709811-8d92-405f-88c0-f0ca32141231	12/31/14	11:33
bp-d4eb76a9-7baa-40b3-8788-980da2141231	12/31/14	10:53
bp-5b94254a-c7b5-4a3d-a66b-a77552141231	12/31/14	10:53

Comment 2

[Richard Newman [:rnewman]]

According to crash-stats, there are five crashes, which I guess are all yours.

Do you have a Chromecast, Roku, Matchstick, or similar on your network?

Are you on wifi during the crash?

What happens if you turn wifi off?

Comment 3

[Richard Newman [:rnewman]]

FWIW, I cannot reproduce on KitKat with both Roku and Chromecast on my home wifi, or with wifi off.

Comment 4

[Richard Newman [:rnewman]]

This is the culprit:

ChromeCast.java:


    public JSONObject toJSON() {
        final JSONObject obj = new JSONObject();
        try {
            final CastDevice device = CastDevice.getFromBundle(route.getExtras());
            if (device == null) {
                return null;             <<<<<
            }


MediaPlayerManager.java:

                    GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent(
                            "MediaPlayer:Added", display.toJSON().toString()));
                                                         ^^^^^^^^^^^^^^^^^


So I'm guessing you have a Chromecast on your network.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Don't crash on startup when CastDevice.getFromBundle returns null. v1

Only needs one reviewer, but very likely one or both is AFK.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Richard Newman [:rnewman] from comment #2)
> According to crash-stats, there are five crashes, which I guess are all
> yours.
> 
> Do you have a Chromecast, Roku, Matchstick, or similar on your network?

None of the above.

> Are you on wifi during the crash?

Yes.

> What happens if you turn wifi off?

Didn't try that. I rolled back to yesterday's build which worked fine. I can try again with today's build and Wi-Fi off.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Doesn't crash with Wi-Fi off. But it's definitely something in today's nightly that's triggering it. I can bisect tomorrow if you think that would be useful.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Turning on Wi-Fi with nightly running also makes it crash.

https://crash-stats.mozilla.com/report/index/bbdc5494-24a9-4710-9ac6-5b60a2150101

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8543099 [details] [diff] [review]
Don't crash on startup when CastDevice.getFromBundle returns null. v1

LGTM

Comment 10

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/e7c220d7f827

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7c220d7f827

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Fixes the crash for me, thanks.

Comment 13

[Richard Newman [:rnewman]]

Landed 10+ days ago, so this is status=fixed.