1117068 - Some configure cleanup.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Remove an obsolete opt-out to the Perl version check

This opt-out was introduced to avoid breaking the builds on a "btek" builder,
about which very little information can be found today.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Remove checks for GCC PR 39608

The fix is included in GCC 4.4, which is our minimum supported version.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Remove NEED_CPP_UNUSED_IMPLEMENTATIONS

It is only used in one place, and that place is better off with MOZ_DELETE.

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8543249 [details] [diff] [review]
Part a: Remove an obsolete opt-out to the Perl version check

># HG changeset patch
># User Ms2ger <[e-mail]>
># Date 1420195915 -3600
>#      Fri Jan 02 11:51:55 2015 +0100
># Node ID 258e0f191f89dc319789e03fce36473407aa8591
># Parent  67872ce1791816b5b0a273ea4b74aba6ce4b84a1
>Bug 1117068 - Part a: Remove an obsolete opt-out to the Perl version check; r=mshal
>
>This opt-out was introduced to avoid breaking the builds on a "btek" builder,
>about which very little information can be found today.
>
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>@@ -756,26 +756,24 @@
> AC_SUBST(MOZ_MSVC_STL_WRAP__RAISE)
> 
> dnl ========================================================
> dnl Checks for programs.
> dnl ========================================================
> AC_PROG_INSTALL
> AC_PROG_LN_S
> 
>-if test -z "$TINDERBOX_SKIP_PERL_VERSION_CHECK"; then

This also exists in js/src/configure.in - mind as well get rid of it there too.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd703663a952
https://hg.mozilla.org/integration/mozilla-inbound/rev/61fb6a19f9ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d323b539934

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd703663a952
https://hg.mozilla.org/mozilla-central/rev/61fb6a19f9ac
https://hg.mozilla.org/mozilla-central/rev/2d323b539934