Closed Bug 1117068 Opened 5 years ago Closed 5 years ago

Some configure cleanup.

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(3 files)

No description provided.
This opt-out was introduced to avoid breaking the builds on a "btek" builder,
about which very little information can be found today.
Attachment #8543249 - Flags: review?(mshal)
The fix is included in GCC 4.4, which is our minimum supported version.
Attachment #8543250 - Flags: review?(mshal)
It is only used in one place, and that place is better off with MOZ_DELETE.
Attachment #8543251 - Flags: review?(mshal)
Comment on attachment 8543249 [details] [diff] [review]
Part a: Remove an obsolete opt-out to the Perl version check

># HG changeset patch
># User Ms2ger <ms2ger@gmail.com>
># Date 1420195915 -3600
>#      Fri Jan 02 11:51:55 2015 +0100
># Node ID 258e0f191f89dc319789e03fce36473407aa8591
># Parent  67872ce1791816b5b0a273ea4b74aba6ce4b84a1
>Bug 1117068 - Part a: Remove an obsolete opt-out to the Perl version check; r=mshal
>
>This opt-out was introduced to avoid breaking the builds on a "btek" builder,
>about which very little information can be found today.
>
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>@@ -756,26 +756,24 @@
> AC_SUBST(MOZ_MSVC_STL_WRAP__RAISE)
> 
> dnl ========================================================
> dnl Checks for programs.
> dnl ========================================================
> AC_PROG_INSTALL
> AC_PROG_LN_S
> 
>-if test -z "$TINDERBOX_SKIP_PERL_VERSION_CHECK"; then

This also exists in js/src/configure.in - mind as well get rid of it there too.
Attachment #8543249 - Flags: review?(mshal) → review+
Attachment #8543250 - Flags: review?(mshal) → review+
Attachment #8543251 - Flags: review?(mshal) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.