Closed Bug 1117071 Opened 10 years ago Closed 10 years ago

Mozharness is failing due to non-determinism in worst status

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

Product:
Release Engineering
Component:
Applications: MozharnessCore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4266] )

Attachments

(1 file, 1 obsolete file)

[mozharness] fix status v2
1.49 KB, patch
rail
: review+
Callek
: checked-in+
Details | Diff | Splinter Review
Attached patch [mozharness] fix status (obsolete) — — Splinter Review
So, mozharness is failing travis, in an intermittent fashion. AFAICT this is due to a code issue TBPL_STATUS_DICT.keys() being used to check which of those keys is worse (at http://hg.mozilla.org/build/mozharness/file/88c4800a33cb/mozharness/mozilla/buildbot.py#l89 ) You can't rely on order of the dictionary keys, and OrderedDict feels cumbersome here, for little gain. Attached is a patch to fix this.
Attachment #8543252 - Flags: review?(rail)
p.s. I initially approved this code :/ Bug 876159
Whops, we already have a var for this.
Attachment #8543252 - Attachment is obsolete: true
Attachment #8543252 - Flags: review?(rail)
Attachment #8543253 - Flags: review?(rail)
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4266]
Attachment #8543253 - Flags: review?(rail) → review+
mozharness has been merged to production. patches are live :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: