Closed Bug 1117115 Opened 5 years ago Closed 5 years ago

Enable test_settings_sim_manager.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: jlorenzo)

References

()

Details

Attachments

(2 files)

46 bytes, text/x-github-pull-request
martijn.martijn
: review+
viorela
: review+
Details | Review
46 bytes, text/x-github-pull-request
viorela
: review+
Details | Review
Attached file Gaia PR
The change is bigger than I expected. I refactored the test to test it against the 2 SIMs. I also changed the return of the 3 properties in order to assert against the visible UI (and not a hidden value of the DOM). By the way _get_displayed_sim might worth it to move in Base because it solves a general problem with <select>.

Tell me what you guys think.
Attachment #8543310 - Flags: review?(viorela.ioia)
Attachment #8543310 - Flags: review?(martijn.martijn)
(In reply to Martijn Wargers [:mwargers] (QA) from comment #1)
These tests should (not) run on DSDS devices. But in this case, we don't actually need 2 SIMs in there. We don't need to add dsds = true there.
Wow, this certainly turned out to be bigger than I thought!
Comment on attachment 8543310 [details] [review]
Gaia PR

Looks good, thanks for fixing!
Attachment #8543310 - Flags: review?(martijn.martijn) → review+
QA Whiteboard: [fxosqa-auto-s7+][fxosqa-auto-points=1]
Attachment #8543310 - Flags: review?(gmealer)
Comment on attachment 8543310 [details] [review]
Gaia PR

r+
Attachment #8543310 - Flags: review?(viorela.ioia) → review+
Merged in: https://github.com/mozilla-b2g/gaia/commit/c72742e62e238b9f6eae4818c378f1a0b5225fd7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attachment #8543310 - Flags: review?(gmealer)
Backed out because this test was running (and failing) on Treeherder: https://github.com/mozilla-b2g/gaia/commit/c67fb679c90372e42e5c48df48da7ccac8047211
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh, this test needs to be skipped on desktop, as it requires SIM existance.
I missed that during review. 
Johan, can you please open a new PR and add the skip of this test on desktop? Thanks!
Attached file Gaia PR - second try
I only changed the manifest.

GIP tests are green on Treeherder: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=3b04329dd562
Attachment #8545221 - Flags: review?(viorela.ioia)
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.