1117115 - Enable test_settings_sim_manager.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

test_settings_sim_manager.py was disabled in bug 1020236, presumably there were no tests with 2 sims in it.
But we have those now.

http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini#85
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_sim_manager.py

Comment 1

[Martijn Wargers (dead)]

I'm also wondering about these bit strange run-if/skip-if calls in:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini#36
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini#36
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini#43

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

The change is bigger than I expected. I refactored the test to test it against the 2 SIMs. I also changed the return of the 3 properties in order to assert against the visible UI (and not a hidden value of the DOM). By the way _get_displayed_sim might worth it to move in Base because it solves a general problem with <select>.

Tell me what you guys think.

Comment 3

[Johan Lorenzo [:jlorenzo]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #1)
These tests should (not) run on DSDS devices. But in this case, we don't actually need 2 SIMs in there. We don't need to add dsds = true there.

Comment 4

[Martijn Wargers (dead)]

Wow, this certainly turned out to be bigger than I thought!

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8543310 [details] [review]
Gaia PR

Looks good, thanks for fixing!

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8543310 [details] [review]
Gaia PR

r+

Comment 7

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/c72742e62e238b9f6eae4818c378f1a0b5225fd7

Comment 8

[Johan Lorenzo [:jlorenzo]]

Backed out because this test was running (and failing) on Treeherder: https://github.com/mozilla-b2g/gaia/commit/c67fb679c90372e42e5c48df48da7ccac8047211

Comment 9

[Viorela Ioia [:viorela]]

Oh, this test needs to be skipped on desktop, as it requires SIM existance.
I missed that during review. 
Johan, can you please open a new PR and add the skip of this test on desktop? Thanks!

Comment 10

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR - second try

I only changed the manifest.

GIP tests are green on Treeherder: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=3b04329dd562

Comment 11

[Viorela Ioia [:viorela]]

Comment on attachment 8545221 [details] [review]
Gaia PR - second try

Merged in: https://github.com/mozilla-b2g/gaia/commit/29370b92526d4ad526182764f6a069e6078ccb90