1117138 - Move incoming call views from conversation.jsx to conversationViews.jsx

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

There's a number of views relating to incoming calls for the desktop that I want to move to conversationViews.jsx.

This is a better location for them as it puts them with the rest of their relevant code. It also puts them in the location I'll want them for bug 1088672 which will simplify the diffs for that bug.

Comment 1

[Mark Banner (:standard8)]

Attachment: Move incoming call views from conversation.jsx to conversationViews.jsx.

This does the simple move of views between the two locations. The view and test code was directly cut and pasted - the only changes being loop.conversation -> loop.conversationViews in various places.

Most of this code is being rewritten/touches (apart from the view renderings) in bug 1088672, so I haven't looked at tidying up the styles or anything.

Comment 2

[Mark Banner (:standard8)]

Attachment: Move incoming call views from conversation.jsx to conversationViews.jsx.

Updated to fix ui showcase bustage.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8543958 [details] [diff] [review]
Move incoming call views from conversation.jsx to conversationViews.jsx.

Review of attachment 8543958 [details] [diff] [review]:
-----------------------------------------------------------------

Tested, approved.

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/74e0fa90d54c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74e0fa90d54c