Closed Bug 1117138 Opened 5 years ago Closed 5 years ago

Move incoming call views from conversation.jsx to conversationViews.jsx

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
2

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37
Iteration:
37.3 - 12 Jan

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file, 1 obsolete file)

There's a number of views relating to incoming calls for the desktop that I want to move to conversationViews.jsx.

This is a better location for them as it puts them with the rest of their relevant code. It also puts them in the location I'll want them for bug 1088672 which will simplify the diffs for that bug.
This does the simple move of views between the two locations. The view and test code was directly cut and pasted - the only changes being loop.conversation -> loop.conversationViews in various places.

Most of this code is being rewritten/touches (apart from the view renderings) in bug 1088672, so I haven't looked at tidying up the styles or anything.
Attachment #8543305 - Flags: review?(nperriault)
Updated to fix ui showcase bustage.
Attachment #8543305 - Attachment is obsolete: true
Attachment #8543305 - Flags: review?(nperriault)
Attachment #8543958 - Flags: review?(nperriault)
Comment on attachment 8543958 [details] [diff] [review]
Move incoming call views from conversation.jsx to conversationViews.jsx.

Review of attachment 8543958 [details] [diff] [review]:
-----------------------------------------------------------------

Tested, approved.
Attachment #8543958 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/74e0fa90d54c
Flags: qe-verify-
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.