Closed
Bug 1117345
Opened 9 years ago
Closed 9 years ago
Can't choose a resolution when trying to resolve a bug (with canconfirm rights)
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pollti, Assigned: glob)
Details
Attachments
(2 files)
93.52 KB,
image/png
|
Details | |
1.73 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
I have canconfirm rights, but can't choose a resolution when selecting RESOLVED for bugs, someone other has filed, so it leads to an error: "A valid resolution is required to mark bugs as RESOLVED."
it appears it has been this way for a long time :| this should make the code match the following comment: # Canconfirm is really "cantriage"; users with canconfirm can also mark # bugs as DUPLICATE, WORKSFORME, and INCOMPLETE.
Attachment #8543786 -
Flags: review?(gerv)
Comment 2•9 years ago
|
||
Comment on attachment 8543786 [details] [diff] [review] 1117345_1.patch Review of attachment 8543786 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/BMO/Extension.pm @@ +516,4 @@ > ($new_value eq 'DUPLICATE' || > $new_value eq 'WORKSFORME' || > + $new_value eq 'INCOMPLETE' || > + ($old_value eq '' && $new_value eq '1'))) I don't understand this line...?
(In reply to Gervase Markham [:gerv] from comment #2) > > + ($old_value eq '' && $new_value eq '1'))) > > I don't understand this line...? calls to check_can_change_field pass '1' as the new_value: en/default/bug/knob.html.tmpl 35: OR bug.check_can_change_field('resolution', bug.resolution, 1) 46: editable = bug.check_can_change_field('resolution', bug.resolution, 1)
Comment 4•9 years ago
|
||
Comment on attachment 8543786 [details] [diff] [review] 1117345_1.patch Review of attachment 8543786 [details] [diff] [review]: ----------------------------------------------------------------- r=gerv. Gerv
Attachment #8543786 -
Flags: review?(gerv) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git d7a8c55..c00b9c3 master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•