1117345 - Can't choose a resolution when trying to resolve a bug (with canconfirm rights)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Tim [:pollti]]

Attachment: bug_bmoresolutionmissing.png

I have canconfirm rights, but can't choose a resolution when selecting RESOLVED for bugs, someone other has filed, so it leads to an error: "A valid resolution is required to mark bugs as RESOLVED."

Comment 1

[:glob ✱]

Attachment: 1117345_1.patch

it appears it has been this way for a long time :|

this should make the code match the following comment:

# Canconfirm is really "cantriage"; users with canconfirm can also mark
# bugs as DUPLICATE, WORKSFORME, and INCOMPLETE.

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 8543786 [details] [diff] [review]
1117345_1.patch

Review of attachment 8543786 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/BMO/Extension.pm
@@ +516,4 @@
>                 ($new_value eq 'DUPLICATE' ||
>                  $new_value eq 'WORKSFORME' ||
> +                $new_value eq 'INCOMPLETE' ||
> +                ($old_value eq '' && $new_value eq '1')))

I don't understand this line...?

Comment 3

[:glob ✱]

(In reply to Gervase Markham [:gerv] from comment #2)
> > +                ($old_value eq '' && $new_value eq '1')))
> 
> I don't understand this line...?

calls to check_can_change_field pass '1' as the new_value:

en/default/bug/knob.html.tmpl
35:        OR bug.check_can_change_field('resolution', bug.resolution, 1)
46:      editable = bug.check_can_change_field('resolution', bug.resolution, 1)

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 8543786 [details] [diff] [review]
1117345_1.patch

Review of attachment 8543786 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d7a8c55..c00b9c3  master -> master