Can't choose a resolution when trying to resolve a bug (with canconfirm rights)

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pollti, Assigned: glob)

Tracking

Production
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

5 years ago
I have canconfirm rights, but can't choose a resolution when selecting RESOLVED for bugs, someone other has filed, so it leads to an error: "A valid resolution is required to mark bugs as RESOLVED."
Assignee

Updated

5 years ago
Assignee: nobody → glob
Component: General → Extensions: BMO
Assignee

Comment 1

5 years ago
it appears it has been this way for a long time :|

this should make the code match the following comment:

# Canconfirm is really "cantriage"; users with canconfirm can also mark
# bugs as DUPLICATE, WORKSFORME, and INCOMPLETE.
Attachment #8543786 - Flags: review?(gerv)
Comment on attachment 8543786 [details] [diff] [review]
1117345_1.patch

Review of attachment 8543786 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/BMO/Extension.pm
@@ +516,4 @@
>                 ($new_value eq 'DUPLICATE' ||
>                  $new_value eq 'WORKSFORME' ||
> +                $new_value eq 'INCOMPLETE' ||
> +                ($old_value eq '' && $new_value eq '1')))

I don't understand this line...?
Assignee

Comment 3

5 years ago
(In reply to Gervase Markham [:gerv] from comment #2)
> > +                ($old_value eq '' && $new_value eq '1')))
> 
> I don't understand this line...?

calls to check_can_change_field pass '1' as the new_value:

en/default/bug/knob.html.tmpl
35:        OR bug.check_can_change_field('resolution', bug.resolution, 1)
46:      editable = bug.check_can_change_field('resolution', bug.resolution, 1)
Comment on attachment 8543786 [details] [diff] [review]
1117345_1.patch

Review of attachment 8543786 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv
Attachment #8543786 - Flags: review?(gerv) → review+
Assignee

Comment 5

5 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   d7a8c55..c00b9c3  master -> master
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.