Closed
Bug 1117466
Opened 10 years ago
Closed 10 years ago
Fix Android gcc warnings in js/src/gc
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.79 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Fix the following Android gcc warnings:
js/src/gc/RootMarking.cpp:124:1 [-Wunused-function] 'void MarkExactStackRoots(js::ThreadSafeContext*, JSTracer*)' defined but not used
js/src/gc/Statistics.cpp:428:44 [-Wsign-compare] comparison between signed and unsigned integer expressions
Also mark global variable `phaseExtra` as static because it's never referenced outside gc/Statistics.cpp.
Attachment #8543580 -
Flags: review?(sphink)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8543580 [details] [diff] [review]
android-gc-warnings.patch
Review of attachment 8543580 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8543580 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•