Closed
Bug 1117662
Opened 9 years ago
Closed 8 years ago
video recording have green bar on left side
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
blocking-b2g | 2.2+ |
People
(Reporter: behsieh, Assigned: mwu)
Details
Attachments
(6 files, 5 obsolete files)
recorded video file in Android L porting have green bar in left side.
Reporter | ||
Comment 1•9 years ago
|
||
root cause is , in Android.mk under device/lge/hammerhead/camera/QCamera2/stack/mm-camera-interface there is a define as below ifeq ($(call is-board-platform-in-list,msm8974 msm8226),true) LOCAL_CFLAGS += -DVENUS_PRESENT endif we can not find this define is-board-platform-in-list in 2.2 code base.
Flags: needinfo?(mvines)
Comment 2•9 years ago
|
||
It's usually in device/qcom/common/utils.mk, such as https://www.codeaurora.org/cgit/quic/la/device/qcom/common/tree/utils.mk?id=LNX.LA.3.7.2.1.c4-01700-8x16.0#n98
Flags: needinfo?(mvines)
Reporter | ||
Comment 3•9 years ago
|
||
I get code from codeaurora from below link https://www.codeaurora.org/cgit/quic/la/device/qcom/common/?h=l_master looks like utils.mk included by base.mk and base.mk include by common.mk and common64.mk in my code base , i could not found who include common.mk or common64.mk
Flags: needinfo?(mvines)
Comment 4•9 years ago
|
||
Here's one such example: https://www.codeaurora.org/cgit/quic/la/platform/vendor/qcom/msm8610/tree/msm8610.mk?h=LA.BF.1.1.1_rb1.1&id=LNX.LA.3.7.2.1.c4-01700-8x16.0#n20 You may want to sync a pure Android build for your N5 as reference.
Flags: needinfo?(mvines)
Reporter | ||
Comment 5•9 years ago
|
||
fix camera green bar in left side
Attachment #8545639 -
Flags: review?(kli)
Reporter | ||
Comment 6•9 years ago
|
||
fix camera green bar in left side
Attachment #8545640 -
Flags: review?(kli)
Comment 7•9 years ago
|
||
Comment on attachment 8545640 [details] [review] enable VENUS on 8974 and 8226 platform Looks good to me.
Attachment #8545640 -
Flags: review?(kli) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8545639 [details] [review] enable VENUS on 8974 and 8226 platform Looks good to me.
Updated•9 years ago
|
Attachment #8545639 -
Flags: review?(kli) → review+
Comment 9•9 years ago
|
||
https://github.com/mozilla-b2g/b2g-manifest/commit/62d6773500827ed8a6855f32392022ba004d6f62 https://github.com/mozilla-b2g/device-hammerhead/commit/ad8030b3b32b9a78116db6b605b3e1d90bf0fda0
Assignee: nobody → behsieh
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 10•9 years ago
|
||
This commit is missed in 2.2 branch. Without this camera recording will get some issue.
blocking-b2g: --- → 2.2?
Reporter | ||
Comment 11•9 years ago
|
||
this fix needs to phase in v2.2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•9 years ago
|
blocking-b2g: 2.2? → 2.2+
Comment 12•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/89b3f66acc69f0fa44fb27dce40bfe34eaf6b641
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
Comment 13•9 years ago
|
||
I've confirmed that my tree has the attached patches, but I'm still seeing green stripes down the sides of my recorded videos. - gecko master:ba2f5fcd614709cb2ec0a69d685c89bc8d454c9b - gaia master:be64e0a1412c1b8c40b7597c77ed16841bdb152f User-facing camera: stripe is 32px wide, on the right side of the video. Away-facing camera: stripe is 16px wide, on the left side of the video.
Comment 14•9 years ago
|
||
Updated•9 years ago
|
Attachment #8560100 -
Attachment description: framegrab showing green stripe (frame should be rotated 90° clockwise) → framegrab showing green stripe (frame should be rotated 90° clockwise) - away-facing camera
Reporter | ||
Comment 15•9 years ago
|
||
hi mike: i just do repo sync and clean build. stripe seems not exist. you also could check below git whether include fixed patch. B2G/device/lge/hammerhead/camera/QCamera2 commit ad8030b3b32b9a78116db6b605b3e1d90bf0fda0 B2G/.repo/manifests commit 1c965d284fbc9886ce3be156960bf6f23149d832 thanks
Reporter | ||
Comment 16•8 years ago
|
||
from Bug 1120780 comment 34. we will going to revert this patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 17•8 years ago
|
||
Attachment #8545639 -
Attachment is obsolete: true
Attachment #8545640 -
Attachment is obsolete: true
Attachment #8568409 -
Flags: review?(mwu)
Reporter | ||
Comment 18•8 years ago
|
||
Attachment #8568411 -
Flags: review?(mwu)
Assignee | ||
Comment 19•8 years ago
|
||
Comment on attachment 8568411 [details] [review] revert android.mk change This PR is against the wrong branch.
Attachment #8568411 -
Flags: review?(mwu) → review-
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8568409 [details] [review] revert request from caf r=me with a more descriptive commit message. "BUG" in all caps also looks particularly wrong for some reason.
Attachment #8568409 -
Flags: review?(mwu) → review+
Reporter | ||
Comment 21•8 years ago
|
||
change pull request branch to b2g-5.0.0_r6
Attachment #8568411 -
Attachment is obsolete: true
Attachment #8575054 -
Flags: review?(mwu)
Reporter | ||
Comment 22•8 years ago
|
||
change PR branch to b2g-5.0.0_r6
Attachment #8575054 -
Attachment is obsolete: true
Attachment #8575054 -
Flags: review?(mwu)
Attachment #8575057 -
Flags: review?(mwu)
Reporter | ||
Comment 23•8 years ago
|
||
remove a line which is get code from caf
Assignee | ||
Updated•8 years ago
|
Attachment #8575057 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 24•8 years ago
|
||
This ensures that the venus code path is selected without relying on build functions that aren't in our codebase. Fixes the green stripe for me.
Assignee: behsieh → mwu
Attachment #8575057 -
Attachment is obsolete: true
Attachment #8578417 -
Flags: review?(mhabicher)
Comment 25•8 years ago
|
||
Comment on attachment 8578417 [details] [review] Force mmcamera_interface to use the venus codepath LGTM.
Attachment #8578417 -
Flags: review?(mhabicher) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8568409 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8575054 -
Attachment is obsolete: false
Assignee | ||
Comment 26•8 years ago
|
||
https://github.com/mozilla-b2g/device-hammerhead/commit/30c43bc43f4393ad1ff602646d8b641067f83189 https://github.com/mozilla-b2g/device-hammerhead/commit/c37663f828891cf7a49451a04f3f1ce7f7e5c054
Assignee | ||
Comment 27•8 years ago
|
||
Assignee | ||
Comment 28•8 years ago
|
||
https://github.com/mozilla-b2g/b2g-manifest/commit/a36d11cdfe7272f1d47f40d215feb8367b718259 https://github.com/mozilla-b2g/b2g-manifest/commit/dd3e1f4f8fc1d601d6e54a960a2509f2049e25c8
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•