video recording have green bar on left side

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: behsieh, Assigned: mwu)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)

Details

Attachments

(6 attachments, 5 obsolete attachments)

1.59 MB, image/png
Details
1.08 MB, image/png
Details
56 bytes, text/x-github-pull-request
Details | Review
52 bytes, text/x-github-pull-request
Details | Review
56 bytes, text/x-github-pull-request
mikeh
: review+
Details | Review
52 bytes, text/x-github-pull-request
Details | Review
(Reporter)

Description

4 years ago
recorded video file in Android L porting have green bar in left side.
(Reporter)

Comment 1

4 years ago
root cause is , in Android.mk under device/lge/hammerhead/camera/QCamera2/stack/mm-camera-interface
there is a define as below
ifeq ($(call is-board-platform-in-list,msm8974 msm8226),true)
    LOCAL_CFLAGS += -DVENUS_PRESENT
endif
we can not find this define is-board-platform-in-list in 2.2 code base.
Flags: needinfo?(mvines)
(Reporter)

Comment 3

4 years ago
I get code from codeaurora from below link
https://www.codeaurora.org/cgit/quic/la/device/qcom/common/?h=l_master
looks like utils.mk included by base.mk
and base.mk include by common.mk and common64.mk
in my code base , i could not found who include common.mk or common64.mk
Flags: needinfo?(mvines)
Here's one such example: https://www.codeaurora.org/cgit/quic/la/platform/vendor/qcom/msm8610/tree/msm8610.mk?h=LA.BF.1.1.1_rb1.1&id=LNX.LA.3.7.2.1.c4-01700-8x16.0#n20

You may want to sync a pure Android build for your N5 as reference.
Flags: needinfo?(mvines)
(Reporter)

Comment 5

4 years ago
fix camera green bar in left side
Attachment #8545639 - Flags: review?(kli)
(Reporter)

Comment 6

4 years ago
fix camera green bar in left side
Attachment #8545640 - Flags: review?(kli)
Comment on attachment 8545640 [details] [review]
enable VENUS on 8974 and 8226 platform

Looks good to me.
Attachment #8545640 - Flags: review?(kli) → review+
Comment on attachment 8545639 [details] [review]
enable VENUS on 8974 and 8226 platform

Looks good to me.
Attachment #8545639 - Flags: review?(kli) → review+
This commit is missed in 2.2 branch. Without this camera recording will get some issue.
blocking-b2g: --- → 2.2?
(Reporter)

Comment 11

4 years ago
this fix needs to phase in v2.2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
blocking-b2g: 2.2? → 2.2+
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/89b3f66acc69f0fa44fb27dce40bfe34eaf6b641
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
I've confirmed that my tree has the attached patches, but I'm still seeing green stripes down the sides of my recorded videos.

- gecko master:ba2f5fcd614709cb2ec0a69d685c89bc8d454c9b
- gaia  master:be64e0a1412c1b8c40b7597c77ed16841bdb152f

User-facing camera: stripe is 32px wide, on the right side of the video.
Away-facing camera: stripe is 16px wide, on the left side of the video.
Attachment #8560100 - Attachment description: framegrab showing green stripe (frame should be rotated 90° clockwise) → framegrab showing green stripe (frame should be rotated 90° clockwise) - away-facing camera
(Reporter)

Comment 15

4 years ago
hi mike:
i just do repo sync and clean build.
stripe seems not exist.
you also could check below git whether include fixed patch.
B2G/device/lge/hammerhead/camera/QCamera2
commit ad8030b3b32b9a78116db6b605b3e1d90bf0fda0

B2G/.repo/manifests
commit 1c965d284fbc9886ce3be156960bf6f23149d832
thanks
(Reporter)

Comment 16

4 years ago
from Bug 1120780 comment 34.
we will going to revert this patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 17

4 years ago
Posted file revert request from caf (obsolete) —
Attachment #8545639 - Attachment is obsolete: true
Attachment #8545640 - Attachment is obsolete: true
Attachment #8568409 - Flags: review?(mwu)
(Reporter)

Comment 18

4 years ago
Posted file revert android.mk change (obsolete) —
Attachment #8568411 - Flags: review?(mwu)
(Assignee)

Comment 19

4 years ago
Comment on attachment 8568411 [details] [review]
revert android.mk change

This PR is against the wrong branch.
Attachment #8568411 - Flags: review?(mwu) → review-
(Assignee)

Comment 20

4 years ago
Comment on attachment 8568409 [details] [review]
revert request from caf

r=me with a more descriptive commit message. "BUG" in all caps also looks particularly wrong for some reason.
Attachment #8568409 - Flags: review?(mwu) → review+
(Reporter)

Comment 21

4 years ago
change pull request branch to b2g-5.0.0_r6
Attachment #8568411 - Attachment is obsolete: true
Attachment #8575054 - Flags: review?(mwu)
(Reporter)

Comment 22

4 years ago
Posted file revert android.mk change (obsolete) —
change PR branch to b2g-5.0.0_r6
Attachment #8575054 - Attachment is obsolete: true
Attachment #8575054 - Flags: review?(mwu)
Attachment #8575057 - Flags: review?(mwu)
(Reporter)

Comment 23

4 years ago
remove a line which is get code from caf
(Assignee)

Updated

4 years ago
Attachment #8575057 - Flags: review?(mwu) → review+
(Assignee)

Comment 24

4 years ago
This ensures that the venus code path is selected without relying on build functions that aren't in our codebase. Fixes the green stripe for me.
Assignee: behsieh → mwu
Attachment #8575057 - Attachment is obsolete: true
Attachment #8578417 - Flags: review?(mhabicher)
Comment on attachment 8578417 [details] [review]
Force mmcamera_interface to use the venus codepath

LGTM.
Attachment #8578417 - Flags: review?(mhabicher) → review+
(Assignee)

Updated

4 years ago
Attachment #8568409 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #8575054 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.