1117701 - [Flame][Homescreen]Can't enter "Add Smart Collections" view after user uncheck "Remember my choice" and select "Don't share" in App permission page.

Status: VERIFIED WONTFIX

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Norry.L.F(Leave from Mozilla)]

Attachment: Video.MP4

[1.Description]:
[Flame][v2.1][Homescreen]Long press Homescreen and select "Add Smart Collections" for the first time,  uncheck "Remember my choice" and select "Don't share" in App permission page, it will go back to Homescreen.
Attach video:Video.mp4.
Attach logcat:logcat.txt.
Occurrence time:05:24

[2.Testing Steps]: 
Premise:Connect a Wifi.

1.Long press homescreen and select "Add Smart Collections" for the first time.
2.Uncheck "Remember my choice" and select "Don't share" in App permission page.

[3.Expected Result]: 
2.It should enter "Add Smart Collections" view.

[4.Actual Result]: 
2.It will go back to Homescreen.

[5.Reproduction build]: 
Flame 2.1 build:
Gaia-Rev        73be51f998031f06db0cd660c0e388fa621c9f4c
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/05dd053f1d90
Build-ID        20150104001209
Version         34.0

Flame 2.2 build:
Gaia-Rev        c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/55f3224d7513
Build-ID        20150104010206
Version         37.0a1

[6.Reproduction Frequency]: 
Always Recurrence,4/4
TCID: Free Test

Comment 1

[Norry.L.F(Leave from Mozilla)]

Attachment: logcat.txt

Comment 2

[Gregor Wagner [:gwagner]]

Broken functionality

Comment 3

[Ted Clancy [:tedders1]]

Okay, I see what's happening here.

When the user selects "Add Smart Collections", apps/collection/js/create_collection.js calls eme.init(), which returns a promise. 

The eme.init() function is in shared/js/everythingme/eme.js, which calls device.init() in shared/js/everythingme/device.js, which calls navigator.geolocation.getCurrentPosition, which prompts the user to ask if they want to share their location.

But if the user says "Don't share", the promise returned by eme.init() is rejected. The code in create_collection.js doesn't do anything if the promise is rejected, leading to this bug.

However, bug 1118891 removed the geolocation request from device.js, so this bug doesn't actually happen anymore, so I'm resolving bug as this as WONTFIX.