[FFOS7715 v2.1] [dolphin][RIL] FFOS does not support registering network as RAT.

NEW
Unassigned

Status

Firefox OS
RIL
3 years ago
3 years ago

People

(Reporter: 孟宪茂, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sprd Bug 390437)

Attachments

(4 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Comment 1

3 years ago
Created attachment 8543911 [details] [diff] [review]
gaia_select_network.patch

gaia_select_network.patch
(Reporter)

Comment 2

3 years ago
Created attachment 8543912 [details] [diff] [review]
gecko_select_network.patch

gecko_select_network.patch
(Reporter)

Comment 3

3 years ago
Dear shawn,

As the FFOS does not support registering network as RAT, we have added the network type in SPRD RILD and gecko, and I have made the patch in gaia and gecko to support registering network as RAT.

Please help review the patch and check if it exists some risk for our code.

Thanks!
Flags: needinfo?(sku)
(Reporter)

Updated

3 years ago
Whiteboard: sprd Bug 390437

Comment 4

3 years ago
Hi Xianmao:
 The gecko patch you provide is from Gaia to Gecko direction.
However, I did not see any scan result from Gecko to Gaia.

R u sure these patches can work properly?
Flags: needinfo?(sku) → needinfo?(xianmao.meng)
(Reporter)

Comment 5

3 years ago
(In reply to shawn ku [:sku] from comment #4)
> Hi Xianmao:
>  The gecko patch you provide is from Gaia to Gecko direction.
> However, I did not see any scan result from Gecko to Gaia.
> 
> R u sure these patches can work properly?

Hi shawn,

I am sorry to tell you, we have already add the network type from our RILD, gecko and gaia, it is named as type in MozMobileNetworkInfo.

I have tested on 7715ea,it can send act to RILD, and modem can use it to register network and return OK.

I am not sure it is a fine way to solve the issue, and if it has some side effects.
Please help me check.

Thanks!
Flags: needinfo?(xianmao.meng) → needinfo?(sku)

Comment 6

3 years ago
Hi Xianmao:
 I know what you are asking.

My question is:
The gecko patch seems in-complete, we should see MozMobileNetworkInfo with act/rat change, and IDL/webIDL/cpp files change too to complete the whole patch at least.

In your gecko patch, I only see the modification on RILContentHelper.js and ril_worker.js which are not enough for this feature.
Flags: needinfo?(sku) → needinfo?(xianmao.meng)
(Reporter)

Comment 7

3 years ago
(In reply to shawn ku [:sku] from comment #6)
> Hi Xianmao:
>  I know what you are asking.
> 
> My question is:
> The gecko patch seems in-complete, we should see MozMobileNetworkInfo with
> act/rat change, and IDL/webIDL/cpp files change too to complete the whole
> patch at least.
> 
> In your gecko patch, I only see the modification on RILContentHelper.js and
> ril_worker.js which are not enough for this feature.

Hi shawn,

Thanks for your support.

I attach all the modification on IDL/webIDL/cpp files, RILContentHelper.js and ril_worker.js.
Please help me check.

Thanks!
Flags: needinfo?(xianmao.meng) → needinfo?(sku)
(Reporter)

Comment 8

3 years ago
Created attachment 8548650 [details] [diff] [review]
select_network_IDL_webIDL_and_cpp.patch
(Reporter)

Comment 9

3 years ago
Created attachment 8548652 [details] [diff] [review]
select_network_RILContentHelper.patch
(Reporter)

Comment 10

3 years ago
Created attachment 8548653 [details] [diff] [review]
select_network_ril_worker.patch

Updated

3 years ago
Attachment #8543912 - Attachment is obsolete: true
Flags: needinfo?(sku)

Comment 11

3 years ago
Hi Xianmao:
 The latest patch seems work to support act.
(I obsolete the old gecko patch)

Thanks!!
Shawn

Updated

3 years ago
Blocks: 1123554
You need to log in before you can comment on or make changes to this bug.