1117707 - [FFOS7715 v2.1] [dolphin][RIL] FFOS does not support registering network as RAT.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[孟宪茂]

Attachment: gaia_select_network.patch

gaia_select_network.patch

Comment 2

[孟宪茂]

Attachment: gecko_select_network.patch

gecko_select_network.patch

Comment 3

[孟宪茂]

Dear shawn,

As the FFOS does not support registering network as RAT, we have added the network type in SPRD RILD and gecko, and I have made the patch in gaia and gecko to support registering network as RAT.

Please help review the patch and check if it exists some risk for our code.

Thanks!

Comment 4

[shawn ku [:sku]]

Hi Xianmao:
 The gecko patch you provide is from Gaia to Gecko direction.
However, I did not see any scan result from Gecko to Gaia.

R u sure these patches can work properly?

Comment 5

[孟宪茂]

(In reply to shawn ku [:sku] from comment #4)
> Hi Xianmao:
>  The gecko patch you provide is from Gaia to Gecko direction.
> However, I did not see any scan result from Gecko to Gaia.
> 
> R u sure these patches can work properly?

Hi shawn,

I am sorry to tell you, we have already add the network type from our RILD, gecko and gaia, it is named as type in MozMobileNetworkInfo.

I have tested on 7715ea,it can send act to RILD, and modem can use it to register network and return OK.

I am not sure it is a fine way to solve the issue, and if it has some side effects.
Please help me check.

Thanks!

Comment 6

[shawn ku [:sku]]

Hi Xianmao:
 I know what you are asking.

My question is:
The gecko patch seems in-complete, we should see MozMobileNetworkInfo with act/rat change, and IDL/webIDL/cpp files change too to complete the whole patch at least.

In your gecko patch, I only see the modification on RILContentHelper.js and ril_worker.js which are not enough for this feature.

Comment 7

[孟宪茂]

(In reply to shawn ku [:sku] from comment #6)
> Hi Xianmao:
>  I know what you are asking.
> 
> My question is:
> The gecko patch seems in-complete, we should see MozMobileNetworkInfo with
> act/rat change, and IDL/webIDL/cpp files change too to complete the whole
> patch at least.
> 
> In your gecko patch, I only see the modification on RILContentHelper.js and
> ril_worker.js which are not enough for this feature.

Hi shawn,

Thanks for your support.

I attach all the modification on IDL/webIDL/cpp files, RILContentHelper.js and ril_worker.js.
Please help me check.

Thanks!

Comment 8

[孟宪茂]

Attachment: select_network_IDL_webIDL_and_cpp.patch

Comment 9

[孟宪茂]

Attachment: select_network_RILContentHelper.patch

Comment 10

[孟宪茂]

Attachment: select_network_ril_worker.patch

Comment 11

[shawn ku [:sku]]

Hi Xianmao:
 The latest patch seems work to support act.
(I obsolete the old gecko patch)

Thanks!!
Shawn

Comment 12

[BMO Automation]

Firefox OS is not being worked on