Closed Bug 1117735 Opened 5 years ago Closed 5 years ago

Remove PJS test cases

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(4 files)

Most test cases test for getBuildConfiguration().parallelJS.

Some test for this.hasOwnProperty("TypedObject") and then assumes that TO arrays will have a mapPar method; this is wrong.

We should also remove utility code used by the test cases.
Additionally:

- older tests (which have not been run for a long time) compare "typeof ParallelArray" to undefined.
- some test cases mix parallel and non-parallel tests and must be edited suitably.
Additionally, Array.prototype.build is not ES6 and is only defined in SpiderMonkey when PJS is enabled.  Some test cases test for this by testing for TypedObject though (different pattern than listed above).
Attachment #8543952 - Flags: review?(shu) → review+
Attachment #8543953 - Flags: review?(shu) → review+
Said bug is the assumption that TypedObject implies Array.build is available.
Attachment #8544601 - Flags: review?(shu)
Try run of these with preceding and subsequent patches:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc950f7b6012
Attachment #8544601 - Flags: review?(shu) → review+
(In reply to Lars T Hansen [:lth] from comment #8)
> Created attachment 8545099 [details] [diff] [review]
> Edit the names of expected array methods in an xpconnect test.  r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/0776988aacd6
You need to log in before you can comment on or make changes to this bug.