1117735 - Remove PJS test cases

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Lars T Hansen [:lth]]

Most test cases test for getBuildConfiguration().parallelJS.

Some test for this.hasOwnProperty("TypedObject") and then assumes that TO arrays will have a mapPar method; this is wrong.

We should also remove utility code used by the test cases.

Comment 1

[Lars T Hansen [:lth]]

Additionally:

- older tests (which have not been run for a long time) compare "typeof ParallelArray" to undefined.
- some test cases mix parallel and non-parallel tests and must be edited suitably.

Comment 2

[Lars T Hansen [:lth]]

Additionally, Array.prototype.build is not ES6 and is only defined in SpiderMonkey when PJS is enabled.  Some test cases test for this by testing for TypedObject though (different pattern than listed above).

Comment 3

[Lars T Hansen [:lth]]

Attachment: Test cases and supporting files that are removed outright

Comment 4

[Lars T Hansen [:lth]]

Attachment: Test cases that are edited to remove PJS cases or bugs

Comment 5

[Lars T Hansen [:lth]]

Attachment: Another test case that is edited to fix a bug

Said bug is the assumption that TypedObject implies Array.build is available.

Comment 6

[Lars T Hansen [:lth]]

Try run of these with preceding and subsequent patches:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc950f7b6012

Comment 7

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f81514af1687
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e50b9cf0432
https://hg.mozilla.org/integration/mozilla-inbound/rev/097840bded9c

Comment 8

[Lars T Hansen [:lth]]

Attachment: Edit the names of expected array methods in an xpconnect test. r=me

Comment 9

[Lars T Hansen [:lth]]

(In reply to Lars T Hansen [:lth] from comment #8)
> Created attachment 8545099 [details] [diff] [review]
> Edit the names of expected array methods in an xpconnect test.  r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/0776988aacd6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f81514af1687
https://hg.mozilla.org/mozilla-central/rev/2e50b9cf0432
https://hg.mozilla.org/mozilla-central/rev/097840bded9c
https://hg.mozilla.org/mozilla-central/rev/0776988aacd6