Closed Bug 1117736 Opened 10 years ago Closed 10 years ago

geoip lookup should check nsIIOService.offline before attempting lookup

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: markh, Unassigned)

Details

"start offline" is a thing...
Flags: qe-verify?
Flags: firefox-backlog+
Why is this necessary? Shouldn't the request just fail in offline mode, and isn't that OK?
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #1) > Why is this necessary? Shouldn't the request just fail in offline mode, and > isn't that OK? I was thinking about telemetry and the fact these installations will report a zero value for SUCCESS.
Not sure it matters enough to worry about - few people should ever be in offline mode, right? If we get more detailed failure error reporting I guess this might be a fine thing to add an enum value for, but I wouldn't worry about it beyond that.
SGTM
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.