1117746 - Share asset is intermittently missing from recent nightlies

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (Android; Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Build ID: 20150104030205

Steps to reproduce:

Not sure if anyone else has seen it but I'll grab a screenshot when it happens again.

Comment 1

[Paul [pwd]]

Attachment: tmp_10591-Screenshot_2015-01-05-12-39-5261434942.png

Went to another app, returned via recent apps and it's gone. 

Android 5.0 BTW

Comment 2

[Teodora Vermesan (:TeoVermesan)]

I can reproduce this on latest Nightly (05-01-2014) on Alcatel One Touch (Android 4.1.2)
Scenarios:
1. 
With a clean profile, open Firefox and open the menu.
2. 
-Go to a website
-Open the menu => instead of the share icon, there is a blank space
-Close the page and open the menu => the share icon reappears
-Reopen the page and choose gmail from the share option list => the gmail shortcut appears near the blank space
-Tap the blank space, the share option list is opened and choose twitter => the two shortcuts appear next the blank space

Comment 3

[Teodora Vermesan (:TeoVermesan)]

Regression window:
1.mozilla-central:
good build: 31-12-2014
bad build: 01-01-2015
pushlog:http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88037f94b7d7&tochange=3c296aa11c51

2.inbound:
good build: 1420057797
bad build: 1420059539
pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=be2eca32172a&tochange=6294a0c2ce96

Comment 4

[u421692]

Fx-team regression window:
good - ftp://ftp.mozilla.org/pub/mobile/tinderbox-builds/fx-team-android-api-11/1419984420/
bad - ftp://ftp.mozilla.org/pub/mobile/tinderbox-builds/fx-team-android-api-11/1420007940/
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=edccc126caae&tochange=4a7b2b24738a

It seems that this regressed from Bug 1116615

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm looking into this.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: menuitem-action-visibility v0.1

GeckoMenuItem that are "Actions" appear either on the ActionBar or the main menu (as ActionBar-ish items). These Views are not normal MenuItem Views and GeckoMenu.onItemChanged handles their visibility uniquely. If the View and the State get out of sync, we can get a situation where the Action is not visible.

Causing the visibility to alter states, like opening a page where Share is allowed, causes the Action View to become visible.

This patch allows Actions to always trigger onItemChanged when setting visibility, as long as we are not in a batch. This fixes the issue for me.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: menuitem-action-visibility v0.2

Now with a comment

Comment 9

[Richard Newman [:rnewman]]

Comment on attachment 8544012 [details] [diff] [review]
menuitem-action-visibility v0.2

Review of attachment 8544012 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/menu/GeckoMenuItem.java
@@ +445,5 @@
>      @Override
>      public MenuItem setVisible(boolean visible) {
> +        // Action views are not normal menu items and visibility can get out
> +        // of sync unless we dispatch whenever required.
> +        if (mActionEnum > 0 || mVisible != visible) {

Use isActionItem() instead of checking mActionEnum directly.

(ProGuard will inline it, so no perf worries.)

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Landed with tweak:
https://hg.mozilla.org/integration/fx-team/rev/c98966220fd6

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c98966220fd6

Comment 12

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 37.0a1 (2015-01-06)
Device: Motorola Razr (Android 4.1.2)