1117765 - Disabling OpenH264 doesn't suppress the download/update?

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Benjamin Smedberg]

On fx-team, Richard Z reports that setting the pref media.gmp-gmpopenh264.enabled;false still causes the OpenH264 module to be downloaded.

If this is true, it is incorrect behavior. Disabling the plugin should disable both use and download/update of the plugin (for consistency, it should perhaps also delete versions which are already downloaded, though I'm less sure about this).

I'm going to give this to spohl since he's currently working on bug 1089867 which is very related.

Comment 1

[Benjamin Smedberg]

Alexandra, I understand you are QA for WebRTC: could you try reproducing this: set the pref disabled before launching Firefox for the first time with a new profile (by e.g. editing user.js) and see whether OpenH264 is downloaded?

Comment 2

[Stephen A Pohl [:spohl] (OOO until 1/2)]

Attachment: Patch

From [1] I can confirm that we're not currently checking media.gmp-gmpopenh264.enabled for downloads/installs of the OpenH264 module, only media.gmp-gmpopenh264.autoupdate. This doesn't directly affect EME since we were already planning to check for the enabled pref there (see bug 1089867 comment 23), but I'm curious whether or not we also need the autoupdate pref for EME. Will follow up in bug 1089867.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/GMPInstallManager.jsm#437

Comment 3

[Stephen A Pohl [:spohl] (OOO until 1/2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d6c779dc48

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7d6c779dc48

Comment 5

[Ada [:adalucinet]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Alexandra, I understand you are QA for WebRTC: could you try reproducing
> this: set the pref disabled before launching Firefox for the first time with
> a new profile (by e.g. editing user.js) and see whether OpenH264 is
> downloaded?

Indeed, with yesterday's Nightly (2015-01-05), OpenH264 is downloaded despite media.gmp-gmpopenh264.enabled pref is set to false. With latest Nightly (Build ID: 20150106030201), this issue is no longer reproducible. Verified as fixed on Mac OS X 10.9.5, Windows 7 64-bit and Ubuntu 12.03 32-bit.