Closed Bug 1117860 Opened 5 years ago Closed 5 years ago

small refactorings for the recursivemake backend

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

These are really the start of moving lots of things *out* of the recursivemake
backend, but I don't know when I'll be able to complete the larger
refactoring.  So I'm posting these patches to get them out of my queue.
_add_unified_build_rules does quite a lot of work besides adding
makefile rules and variables.  The divying up of source files into
unified files is one part of that, so move it out into its own function.
When we eventually move that computation out of recursivemake.py, this
refactoring will make it easier to verify that's what we've done.
Attachment #8544079 - Flags: review?(mshal)
Writing the unified files is another thing that will have to be moved
out of recursivemake.py eventually.  And it doesn't belong inline amidst
makefile rules and variables.  Move its logic to a separate function as
well.
Attachment #8544080 - Flags: review?(mshal)
Comment on attachment 8544079 [details] [diff] [review]
part 1 - factor sources->unified file computation out of _add_unified_build_rules

>+            return itertools.ifilter(lambda x: x != dummy_fill_value,
>+                                         iterable)

whitespace nit: "iterable" was aligned under "lambda". Though we don't have much consistency for this within the file :)
Attachment #8544079 - Flags: review?(mshal) → review+
Attachment #8544080 - Flags: review?(mshal) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.