1117860 - small refactorings for the recursivemake backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

These are really the start of moving lots of things *out* of the recursivemake
backend, but I don't know when I'll be able to complete the larger
refactoring.  So I'm posting these patches to get them out of my queue.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - factor sources->unified file computation out of _add_unified_build_rules

_add_unified_build_rules does quite a lot of work besides adding
makefile rules and variables.  The divying up of source files into
unified files is one part of that, so move it out into its own function.
When we eventually move that computation out of recursivemake.py, this
refactoring will make it easier to verify that's what we've done.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - factor out unified file writing from _add_unified_build_rules

Writing the unified files is another thing that will have to be moved
out of recursivemake.py eventually.  And it doesn't belong inline amidst
makefile rules and variables.  Move its logic to a separate function as
well.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8544079 [details] [diff] [review]
part 1 - factor sources->unified file computation out of _add_unified_build_rules

>+            return itertools.ifilter(lambda x: x != dummy_fill_value,
>+                                         iterable)

whitespace nit: "iterable" was aligned under "lambda". Though we don't have much consistency for this within the file :)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a862343408d4
https://hg.mozilla.org/mozilla-central/rev/a5dcb0bb6327