Closed Bug 1117864 Opened 5 years ago Closed 5 years ago

Sync plugin instantiation should not pass a runnable to PluginProcessParent::Launch

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file, 1 obsolete file)

This isn't a big deal for correctness right now the way things are written, but currently the runnable is executed for both sync and async init, which isn't future proof (and isn't actually needed in the sync case, so it's a waste of time to execute it).
Attachment #8544272 - Flags: review?(jmathies)
Comment on attachment 8544272 [details] [diff] [review]
Don't set launch runnable unless we're starting async

Review of attachment 8544272 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +366,5 @@
>  {
>      PLUGIN_LOG_DEBUG_FUNCTION;
>  
>      nsAutoPtr<PluginModuleChromeParent> parent(new PluginModuleChromeParent(aFilePath, aPluginId));
> +    UniquePtr<LaunchCompleteTask> onLaunchedRunnable;

can we name this something different, it really threw me at first since it looks like some sort of 'onXYZ' event method. Maybe just 'launchRunnable'?
Attachment #8544272 - Flags: review?(jmathies) → review+
Addressed comment. Carrying forward r+.
Attachment #8544272 - Attachment is obsolete: true
Attachment #8545399 - Flags: review+
On further inspection of this code, I think that it should be left as-is. My bad.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: needinfo?(aklotz)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.