[e10s] Only announce that we're going to open a tab to input.mozilla.org if we're actually going to do it (only in the nightly update channel)

RESOLVED FIXED in Firefox 38

Status

()

Firefox
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: Felipe)

Tracking

unspecified
Firefox 38
x86
Mac OS X
Points:
2
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(e10sm5+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Go to preferences, uncheck the e10s box. A serious of dialogs will appear and tell you that after Nightly restarts a tab to input.mozilla.org will be opened so you can provide feedback. No such tab is ever opened though.
tracking-e10s: ? → m7+
tracking-e10s: m7+ → m5+
Assignee: nobody → dtownsend
(Reporter)

Comment 1

3 years ago
You worked on this originally felipe, want to take this?
Points: --- → 2
Flags: needinfo?(felipc)
Flags: firefox-backlog+
(Assignee)

Comment 2

3 years ago
yep
Assignee: dtownsend → felipc
Status: NEW → ASSIGNED
Flags: needinfo?(felipc)

Updated

3 years ago
Iteration: --- → 37.3 - 12 Jan
(Assignee)

Comment 3

3 years ago
Dave, did you experience this using a local build (instead of nightly build)?
In order to not show most of the e10s prompting all the time for local builds and mochitests, the code responsible for this checks for UpdateChannel.get() == "nightly", which is false for a local build (as the channel is "default").
Removing that condition makes it properly appear on a local build for me.

If you saw this on a regular nightly, we need to dig into it more. Before the restart the code is meant to set the pref browser.requestE10sFeedback to true, and read+clear it after sessionstore-windows-restored on the next startup.
Flags: needinfo?(dtownsend)
(Reporter)

Comment 4

3 years ago
(In reply to :Felipe Gomes from comment #3)
> Dave, did you experience this using a local build (instead of nightly build)?
> In order to not show most of the e10s prompting all the time for local
> builds and mochitests, the code responsible for this checks for
> UpdateChannel.get() == "nightly", which is false for a local build (as the
> channel is "default").
> Removing that condition makes it properly appear on a local build for me.
> 
> If you saw this on a regular nightly, we need to dig into it more. Before
> the restart the code is meant to set the pref browser.requestE10sFeedback to
> true, and read+clear it after sessionstore-windows-restored on the next
> startup.

You're quite right, I think this was with a local build. Can we maybe not show the dialog about the feedback tab opening in the case where it won't?
Flags: needinfo?(dtownsend)

Updated

3 years ago
Flags: qe-verify?

Updated

3 years ago
Iteration: 37.3 - 12 Jan → 38.1 - 26 Jan
(Assignee)

Updated

3 years ago
Summary: [e10s] When disabling e10s a message is displayed saying that after the restart a tab to input.mozilla.org will be opened. It isn't → [e10s] Only announce that we're going to open a tab to input.mozilla.org if we're actually going to do it (only in the nightly update channel)
(Assignee)

Comment 5

3 years ago
Created attachment 8548306 [details] [diff] [review]
patch

the logic ends up duplicated in the two places but it sounds worth the confusion that it will avoid with that message showing up
Attachment #8548306 - Flags: review?(dtownsend)
(Reporter)

Updated

3 years ago
Attachment #8548306 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/2234aaa1655a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Setting as "qe-verify-" as it appears to be a low impact fix.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.