Closed Bug 1118021 Opened 6 years ago Closed 6 years ago

Support FLAC album art (non Vorbis Comment)

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S3 (9jan)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file)

kid3 store the album art in FLAC file as a separate metadata block.

METADATA block #2
  type: 6 (PICTURE)
  is last: false
  length: 596
  type: 3 (Cover (front))
  MIME type: image/jpeg
  description: 
  width: 32
  height: 32
  depth: 32
  colors: 0 (unindexed)
  data length: 554
  data:
    00000000: FF D8 FF E0 00 10 4A 46 49 46 00 01 01 01 00 48 ......JFIF.....H
[...]

The binary representation is the same as the decoded block from VorbisComment.
Depends on: 907929
Assignee: nobody → hub
This is the FLAC cover support.
Attachment #8544738 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

This looks generally good, but I think we should refactor the metadata block fetching a bit, now that it's gotten more complex. I have some comments on GitHub about it.
Attachment #8544738 - Flags: review?(squibblyflabbetydoo) → review-
Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

Addressed comments.

Our tests are still green.
Attachment #8544738 - Flags: review- → review?(squibblyflabbetydoo)
Status: NEW → ASSIGNED
Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

r=me. I have a couple of editorial nits on GitHub, but they're entirely optional.
Attachment #8544738 - Flags: review?(squibblyflabbetydoo) → review+
I'll deal with the nits. No problem. Thanks !
Merged

https://github.com/mozilla-b2g/gaia/commit/97bf6f691bc7b34b5a3a247ca03fe06ed008b3fb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
You need to log in before you can comment on or make changes to this bug.