1118021 - Support FLAC album art (non Vorbis Comment)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

kid3 store the album art in FLAC file as a separate metadata block.

METADATA block #2
  type: 6 (PICTURE)
  is last: false
  length: 596
  type: 3 (Cover (front))
  MIME type: image/jpeg
  description: 
  width: 32
  height: 32
  depth: 32
  colors: 0 (unindexed)
  data length: 554
  data:
    00000000: FF D8 FF E0 00 10 4A 46 49 46 00 01 01 01 00 48 ......JFIF.....H
[...]

The binary representation is the same as the decoded block from VorbisComment.

Comment 1

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

This is the FLAC cover support.

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

This looks generally good, but I think we should refactor the metadata block fetching a bit, now that it's gotten more complex. I have some comments on GitHub about it.

Comment 3

[Hubert Figuiere [:hub]]

Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

Addressed comments.

Our tests are still green.

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8544738 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27169

r=me. I have a couple of editorial nits on GitHub, but they're entirely optional.

Comment 5

[Hubert Figuiere [:hub]]

I'll deal with the nits. No problem. Thanks !

Comment 6

[Hubert Figuiere [:hub]]

Merged

https://github.com/mozilla-b2g/gaia/commit/97bf6f691bc7b34b5a3a247ca03fe06ed008b3fb