Closed Bug 1118038 Opened 5 years ago Closed 5 years ago

Remove the JIT parts of PJS

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: shu, Assigned: shu)

References

Details

Attachments

(1 file, 1 obsolete file)

What this bug will not cover removing:

 - The ParallelExecution ExecutionMode
 - ForkJoin (incl. simplifying the Context hierarchy)
 - VM functions that had extra paths added
 - GC functions that had extra paths added
Attached patch Remove JIT parts of PJS. (obsolete) — Splinter Review
Have fun.
Attachment #8544262 - Flags: review?(lhansen)
Blocks: removepjs
Oops, forgot about the other architectures.
Attachment #8544262 - Attachment is obsolete: true
Attachment #8544262 - Flags: review?(lhansen)
Attachment #8544284 - Flags: review?(lhansen)
Comment on attachment 8544284 [details] [diff] [review]
Remove JIT parts of PJS.

Review of attachment 8544284 [details] [diff] [review]:
-----------------------------------------------------------------

Massive, but thankfully largely mechanical in nature.  Nits:

Something left undone here?

--- a/js/src/vm/ForkJoin.cpp
+++ b/js/src/vm/ForkJoin.cpp
@@ -809,26 +809,19 @@ ForkJoinOperation::appendCallTargetsToWorklist(uint32_t index, ExecutionStatus *
+    // TODOshu remove


Function CanEnterInParallel can be removed now if the single call to it in ForkJoin.cpp is removed:

diff --git a/js/src/jit/Ion.cpp b/js/src/jit/Ion.cpp
@@ -2350,68 +2252,30 @@ jit::CompileFunctionForBaseline(JSContext *cx, HandleScript script, BaselineFram
 MethodStatus
 jit::CanEnterInParallel(JSContext *cx, HandleScript script)
 {
 ...
-    return Method_Compiled;
+    return Method_Error;
Attachment #8544284 - Flags: review?(lhansen) → review+
(In reply to Lars T Hansen [:lth] from comment #3)
> Comment on attachment 8544284 [details] [diff] [review]
> Remove JIT parts of PJS.
> 
> Review of attachment 8544284 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Massive, but thankfully largely mechanical in nature.  Nits:
> 
> Something left undone here?
> 
> --- a/js/src/vm/ForkJoin.cpp
> +++ b/js/src/vm/ForkJoin.cpp
> @@ -809,26 +809,19 @@
> ForkJoinOperation::appendCallTargetsToWorklist(uint32_t index,
> ExecutionStatus *
> +    // TODOshu remove
> 
> 
> Function CanEnterInParallel can be removed now if the single call to it in
> ForkJoin.cpp is removed:
> 
> diff --git a/js/src/jit/Ion.cpp b/js/src/jit/Ion.cpp
> @@ -2350,68 +2252,30 @@ jit::CompileFunctionForBaseline(JSContext *cx,
> HandleScript script, BaselineFram
>  MethodStatus
>  jit::CanEnterInParallel(JSContext *cx, HandleScript script)
>  {
>  ...
> -    return Method_Compiled;
> +    return Method_Error;

I wanted to avoid touching the vm/ stuff too much, but it's probably not too bad in this case to just remove the call in ForkJoin.cpp
Assignee: nobody → shu
Appears to have landed on m-i:

changeset:   222596:7584b643e7e9
user:        Shu-yu Guo <shu@rfrn.org>
date:        Wed Jan 07 01:18:42 2015 -0800
summary:     Bug 1118038 - Remove JIT parts of PJS. (r=lth)
https://hg.mozilla.org/mozilla-central/rev/7584b643e7e9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1135794
You need to log in before you can comment on or make changes to this bug.