Closed
Bug 1118039
Opened 10 years ago
Closed 10 years ago
testSystemPages is disabled on x86 but runs anyway
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
946 bytes,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Robocop testSystemPages is disabled on Android 2.3 and Android x86, but it appears that it is running on Android x86. http://hg.mozilla.org/mozilla-central/annotate/51ca6ef95772/mobile/android/base/tests/robocop.ini#l92 http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android-x86/1420457622/mozilla-central_ubuntu64_hw_test-androidx86-set-4-bm105-tests1-linux-build612.txt.gz
![]() |
Assignee | |
Comment 1•10 years ago
|
||
Other tests are correctly skipped: 06:27:35 INFO - TEST-INFO | skipping testAddonManager | skip-if: android_version == "10" || processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testAdobeFlash | skip-if: processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testAxisLocking | skip-if: processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testClearPrivateData | skip-if: android_version == "10" || processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testFlingCorrectness | skip-if: processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testHomeBanner | skip-if: processor == "x86" 06:27:35 INFO - TEST-INFO | skipping testImportFromAndroid | skip-if: android_version == "10" || processor == "x86"
![]() |
Assignee | |
Comment 2•10 years ago
|
||
http://hg.mozilla.org/mozilla-central/diff/51ca6ef95772/mobile/android/base/tests/robocop.ini deleted a test but did not delete the skip-if associated with it, creating more than one skip-if rule for testSystemPages.
Attachment #8544267 -
Flags: review?(margaret.leibovic)
![]() |
Assignee | |
Updated•10 years ago
|
Summary: Some robocop tests disabled on x86 are running on x86 → testSystemPages is disabled on x86 but runs anyway
Comment 3•10 years ago
|
||
Comment on attachment 8544267 [details] [diff] [review] fix robocop.ini Review of attachment 8544267 [details] [diff] [review]: ----------------------------------------------------------------- /me shakes fist at confusing skip-if syntax. Good catch!
Attachment #8544267 -
Flags: review?(margaret.leibovic) → review+
![]() |
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cde6c13407c
https://hg.mozilla.org/mozilla-central/rev/8cde6c13407c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•