1118039 - testSystemPages is disabled on x86 but runs anyway

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

Robocop testSystemPages is disabled on Android 2.3 and Android x86, but it appears that it is running on Android x86.

http://hg.mozilla.org/mozilla-central/annotate/51ca6ef95772/mobile/android/base/tests/robocop.ini#l92

http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android-x86/1420457622/mozilla-central_ubuntu64_hw_test-androidx86-set-4-bm105-tests1-linux-build612.txt.gz

Comment 1

[Geoff Brown [:gbrown]]

Other tests are correctly skipped:

06:27:35     INFO -  TEST-INFO | skipping testAddonManager | skip-if: android_version == "10" || processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testAdobeFlash | skip-if: processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testAxisLocking | skip-if: processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testClearPrivateData | skip-if: android_version == "10" || processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testFlingCorrectness | skip-if: processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testHomeBanner | skip-if: processor == "x86"
06:27:35     INFO -  TEST-INFO | skipping testImportFromAndroid | skip-if: android_version == "10" || processor == "x86"

Comment 2

[Geoff Brown [:gbrown]]

Attachment: fix robocop.ini

http://hg.mozilla.org/mozilla-central/diff/51ca6ef95772/mobile/android/base/tests/robocop.ini deleted a test but did not delete the skip-if associated with it, creating more than one skip-if rule for testSystemPages.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8544267 [details] [diff] [review]
fix robocop.ini

Review of attachment 8544267 [details] [diff] [review]:
-----------------------------------------------------------------

/me shakes fist at confusing skip-if syntax.

Good catch!

Comment 4

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cde6c13407c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cde6c13407c