1118052 - [Settings][Internet Sharing / Hotspot] Hotspot settings can be accessed while hotspot is enabled causing changes to not take effect until toggling the hotspot off and back on

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150105_1549.txt

Description:
In 2.2 you are able to change a hotspot's settings after the hotspot has been turned on. These changes do not take effect until you toggle the hotspot off and back on. There is no warning about this and users may make a change and then encounter what they will interpret as broken functionality. 
This is opposed to 2.1 where the option to change the settings is greyed out / inaccessible until you toggle the hotspot to the off position insuring that all changes will be accurately reflected.


Repro Steps:
1) Update a Flame to 20150105010205
2) On test device enable a Wi-Fi hotspot
3) Enter Hotspot Settings and change name
4) On another device search wi-fi networks
5) Observe the Hotspot's original name
6) On the test device toggle the hotspot off and back on
7) On the other device (after a brief pause) refresh the available wi-fi networks.

Optional Additional Steps
8) On the test device enter the hotspot settings and change the password
9) On the other device attempt to connect to the created hotspot using the new password

Actual:
The changes in Hotspot settings are not reflected until toggling it off and on. While the other device can still connect even with different hotspot names being reflected - changing the password and using the new password (without toggling) will prevent the other device from connecting eventually resulting in an error message

Expected:
The changes will be reflected after being made without toggling
<OR> - the user will not be able to make changes with the hotspot toggled on
<OR> - a warning message informing users the must toggle hotspot to enact changes

Environmental Variables:
Device: Flame Master
Build ID: 20150105010205
Gaia: c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko: 636498d041b5
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (Master)
Firmware Version: V18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 5/5
See attached: Logcat

Comment 1

[Peter Bylenga [:PBylenga]]

Functional regression of a core feature.

Requesting a window.

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Hey Arthur, I've made a first approach which disable all the inputs in the hotspot settings panel if the wifi-hotspot is enabled. This could give to the user the possibility of see the current password as well as the current settings.

However, we can disable the access to this panel by adding the aria-disabled attribute to the list element that handle the navigation.

Also, the regression-window is not necessary from my point of view since this is easy to fix and the cause of this issue is a refactor that unified all the styles inside the app (using a tag instead buttons)

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: hotspot-settings-disabled.png

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Removing the regressionwindow-wanted tag per comment 2.  I was almost done with the window and will keep the information set aside if it is determined that this is still desired later.

Comment 5

[howie [:howie]]

Triage: regression, blocking.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8545193 [details] [review]
Proposed patch

Thanks for working on the issue. This is a regression and the behavior before was that when Wi-Fi hotspot is enabled, the list item for hotspot settings is disabled. As users are able to check the SSID and security settings from the internet sharing panel, I think it is fine just disabling the list item.

Comment 7

[Manuel Casas Barrado [:mancas]]

Attachment: hotspot-settings-disabled.png

Comment 8

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8545193 [details] [review]
Proposed patch

Arthur, the patch is working now, as expected.

Thanks!

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8545193 [details] [review]
Proposed patch

r=me, thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/47972cd187a9ee3dbdf455fec214646ce3490c4f

Please request Gaia v2.2 approval on this when you get a chance.

Comment 11

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch for v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Caused by a refactor that set up the same look&feel in the whole app
[User impact] if declined: User can change the hotspot settings with no effect until the feature is switch off and on.
[Testing completed]: Manual test
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f3d9f37665da10e4ee1130912c72a427c052bcbd

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Flame 3.0 and Flame 2.2 builds.  

Actual Results:
The user cannot access Hotspot Settings while the Wi-Fi Hotspot is enabled.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150123010227
Gaia: cba2f0bf49b882e0044c3cc583de8fcf83d2ffa4
Gecko: 494632b9afed
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150123002505
Gaia: 237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko: be24dd482a83
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0