1118058 - direct call: ringback, room-leave, something-went-wrong sounds don't play

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

In Firefox 35 beta 3 on MacOS, ringback and other sounds played from about:loop* contexts don't work.  

http://hg.mozilla.org/mozilla-central/rev/31a2e1b8b32b appears to have been the original working patch in nightly.  Jesup did a bunch of bug hunting in #loop:

<jesup> 11/10 no ringback, no sec error
<jesup> 11/14 no ringback, sec error
<jesup> likely that rev got uplifted to aurora/35 between 11/10 and 11/14, but due to other differences in 35 hits the sec error
<jesup> I note that in the first Aurora/36, I have ringback.

I've added status-firefox 36? because although it doesn't effect the Aurora 36 or Nightly 37, I'm concerned that it's something specific to the beta environment, so that when Aurora 36 uplifts to Beta 36 next week-ish, the problem could actually start occuring there.

The sec error that jesup shows up in the browser console like this:

Security Error: Content at about:loopconversation#a188fe96a7942dbf864c6d76014b8377 may not load data from blob:null/d8f1144d-b6d2-9f42-885d-4469f029ee64

The fact that the blob URL looks like it might have some sort of security problem (eg the fact that it starts with "null") seems like it could be the result of a lack of error checking.

Interestingly, however, the blob URL takes the same format in Nightly, but there, it works.

Standard8 and I poked around a bit, and one possibility is that the content code calls into mozLoop.getAudioBlob() to have a blob created.  When it's cloned into content and used, that appears to be where the security error returns.  Perhaps something is confusing CSP?

Adding a needinfo to abr? for his insights on this.

Comment 1

[u279076]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #0)
> In Firefox 35 beta 3 on MacOS, ringback and other sounds played from
> about:loop* contexts don't work.  

Does this reproduce in an updated beta? Firefox 35.0b8 is the current beta.

Comment 2

[Mike de Boer [:mikedeboer]]

This is due to bug 1088617, which needs to be uplifted to 35 :S

Comment 3

[Mike de Boer [:mikedeboer]]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> This is due to bug 1088617, which needs to be uplifted to 35 :S

...which _does_ change a UUID... so, that's a bit concerning.

Comment 4

[Mark Banner (:standard8)]

Given bug 1088617 comment 3, we probably don't need the uuid change - looks like its just removing dead code.

Comment 5

[Maire Reavy [:mreavy]]

These particular sounds in Fx35 never worked.  NOTE: Fx34 didn't have the ringback sound either; so that's not a regression.

Sounds for leaving a room and something-went-wrong were not initially specified in the UX for rooms, and they are nice-to-have.

All of these sounds are working in Fx36 and later; so I think we should mark this bug (which is for Fx35 only) as "wontfix".

Comment 6

[Mark Banner (:standard8)]

Wontfix per comment 5.