1118084 - Remove self-hosted and user-exposed methods from PJS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

This should be all the entry points into PJS code.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Remove self-hosted and user-exposed PJS methods.

Comment 2

[Lars T Hansen [:lth]]

My only concern here is that the scatter method of TypedObject array is being removed.  Given how carefully it's done I assume it's deliberate; was it introduced solely because of PJS?

Comment 4

[Shu-yu Guo [:shu]]

(In reply to Lars T Hansen [:lth] from comment #2)
> My only concern here is that the scatter method of TypedObject array is
> being removed.  Given how carefully it's done I assume it's deliberate; was
> it introduced solely because of PJS?

Yes, I consulted with Niko and confirmed that scatter was PJS-only, while the other array methods were not.

Comment 5

[Lars T Hansen [:lth]]

Note that when you land this, one test that use scatter without a correct guard will start to fail, the test needs to be rewritten or disabled:

/home/lth/moz/mozilla-inbound/js/src/jit-test/tests/ion/inlining/TypedObject-TypeDescrIsSizedArrayType.js:29:11 TypeError: v.scatter is not a function

Comment 6

[Shu-yu Guo [:shu]]

(In reply to Lars T Hansen [:lth] from comment #5)
> Note that when you land this, one test that use scatter without a correct
> guard will start to fail, the test needs to be rewritten or disabled:
> 
> /home/lth/moz/mozilla-inbound/js/src/jit-test/tests/ion/inlining/TypedObject-
> TypeDescrIsSizedArrayType.js:29:11 TypeError: v.scatter is not a function

Yeah, this patch removes that test.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68d1c3fd25f1

Comment 8

[Kohei Yoshino]

Added to the compat doc: https://developer.mozilla.org/en-US/Firefox/Releases/37/Site_Compatibility