1118085 - [RTL][Settings] Arabic: The "Geolocation" string is truncated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Yeojin Chung [:YeojinC]]

Attachment: Truncate.png

Description:
On Settings page, the string "Geolocation" is truncated in Arabic.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150105010205.
2) Set the device language in Arabic under Settings > Language.
3) Return to the main screen of Settings, and observe the string "Geolocation".
  
Actual:
The string "Geolocation" (تحديد الموقع الجغرافي) is truncated.
  
Expected: 
The string "Geolocation" (تحديد الموقع الجغرافي) is translated properly without truncation.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150105010205
Gaia: 613550ddb8a7b96ed6bf2a39b0b2c7547e5dbf9a
Gecko: 636498d041b5
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: screenshot

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Rami, Ahmed: do you think there is a shorter yet more meaningful string for this, so it fits?

Comment 2

[Rami Khader]

We can use تموضع جغرافي instead

Rami

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Great, thanks for the input Rami! Can you please mark this bug as resolved fixed once you've made the change? thanks!

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: demo.png

It seems that Ahmed is working **** the other RTL bugs, and I think this bug is quite simple to give a fix so I just jumped in.

@Rami, I just captured a screenshot with updated string. Does this one look okay to you or not :) ?

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Arthur, this is a patch that trying to update strings for geolocation in Arabic. Can you help me review this after @Rami gave us f+? thanks :)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8556261 [details] [review]
patch

I believe this should be done by l10n team? This change should be made on their repo.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi @Stats, I remember few weeks ago, we did update Arabic locale to fix wording issues of wifi security in Settings app. I think it's okay for us to update that locale again in this bug, right :) ?

Any information would be appreciated ! Thanks !!

Comment 8

[Rami Khader]

It looks perfect you can go ahead and change it

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8556261 [details] [review]
patch

Hi Arthur, let me put the reviewer on you first based on our offline discussion and let's wait for Stat's reply :)

Comment 10

[Staś Małolepszy :stas]

Arthur is correct in comment 6:

> I believe this should be done by l10n team? This change should be made on
> their repo.

This change should be made by the Arabic team in https://hg.mozilla.org/gaia-l10n/ar, which in turn is managed via http://mozilla.locamotion.org/ar/firefoxos/.  Rami, can you make this change in Locamotion, please?

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8556261 [details] [review]
patch

Cancel the review request per comment 10.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ok, let's redirect this bug to rami.

But I got confused why Stas you told me to update ar locale last time when we were trying to fix security problem in Settings App ? 

hmmmm ~

Comment 13

[Rami Khader]

I updated the string via http://mozilla.locamotion.org/ar/firefoxos and also I changed in different places where it shows too.

Comment 14

[Staś Małolepszy :stas]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #12)
 
> But I got confused why Stas you told me to update ar locale last time when
> we were trying to fix security problem in Settings App ? 

EJ, I must have not expressed myself clearly in the other bug, I'm sorry about that!  In the following comment on github I tried to say that we should be making changes  only to the *.en-US.properties files:

  https://github.com/mozilla-b2g/gaia/pull/26766/files#r22460362

And in bug 1106835 comment 11 I should have explicitly said to edit settings.en-US.properties.

We don't want to update other languages in Gaia repo because all changes are lost anyways when the l10n scripts extract new strings from *.en-US.properties files into https://hg.mozilla.org/gaia-l10n/en-US.  The localizers only ever see the en-US files.

I have a bug assigned to me to disabled and remove all other languages from the Gaia repo: bug 1099321.  I'll move this up my todo list.

Hope this clears any confusion.  Thanks!

Comment 15

[Ahmed Nefzaoui [:Nefzaoui]]

Sorry that I've not been able to reply here in time.
I just checked, the string Rami suggested and pushed to locamotion has successfully landed in Mercurial(1).
However I think this repo links to gaia master only (not quite sure), while the v2.2 l10n repo(2) seems to give a 404 error.

Stas,
How do we make sure this lands in the l10n repo of v2.2?
Thanks!

(1): https://hg.mozilla.org/gaia-l10n/ar/file/61c4b0f03e70/apps/settings/settings.properties#l31
(2): https://hg.mozilla.org/releases/gaia-l10n/v2_2

Comment 16

[Staś Małolepszy :stas]

Flod tells me that https://hg.mozilla.org/gaia-l10n/ar currently still corresponds to 2.2, so we should be good.

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Staś Małolepszy :stas from comment #14)
> (In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #12)
>  
> > But I got confused why Stas you told me to update ar locale last time when
> > we were trying to fix security problem in Settings App ? 
> 
> EJ, I must have not expressed myself clearly in the other bug, I'm sorry
> about that!  In the following comment on github I tried to say that we
> should be making changes  only to the *.en-US.properties files:
> 
>   https://github.com/mozilla-b2g/gaia/pull/26766/files#﷒0﷓
> 
> And in bug 1106835 comment 11 I should have explicitly said to edit
> settings.en-US.properties.
> 
> We don't want to update other languages in Gaia repo because all changes are
> lost anyways when the l10n scripts extract new strings from
> *.en-US.properties files into https://hg.mozilla.org/gaia-l10n/en-US.  The
> localizers only ever see the en-US files.
> 
> I have a bug assigned to me to disabled and remove all other languages from
> the Gaia repo: bug 1099321.  I'll move this up my todo list.
> 
> Hope this clears any confusion.  Thanks!

Okkk, I got it now.

No matter how, we should only update en locale instead of the others ! And I think after bug 1099321 got resolved, we won't have this kind of problem anymore :)

+++

Comment 18

[Ahmed Nefzaoui [:Nefzaoui]]

We're done here :)
Verified this to be working days ago in 3.0 and 2.2.
Thanks Rami!

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Awesome, thanks all for fixing this in Settings app :)

Comment 20

[Martin Shuman [:Marty]]

This issue is verified Fixed on Flame 3.0 and 2.2 builds.
Translated "Geolocation" string is not truncated in Settings.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 21

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15558/