1118095 - [Settings][Dialog] In RTL languages, the fading animation of dialog is wrong

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

As title, in RTL languages, settings dialog can't be shown properly with right animation.

[STR]

1. open Settings app
2. change languages to Arabic 
3. go into wifi panel
4. click on any encrypted wifi and you will see the wrong animation -> KO

[Expected Result]
In RTL languages, animation for Settings dialog should be right.

[Actual Result]
In RTL languages, animation for Settings dialog should is wrong.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur, can you help me review this simple patch ? Thanks :)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8544319 [details] [review]
patch on master

r=me, thanks!

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/d0b32fe9a454d96f2f3f0492714e7523df33cb98

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8544319 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: RTL users would notice the weird animation.
[Testing completed]: no, this is one-line CSS change.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9a2487186b6c8b7ac0a380227cfa48edeac27e63

Comment 6

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: The transition into the Wi-Fi password screen is correct, instead of the animation sliding from left to right.
 
Device: Flame 2.2 (319mb, full flash)
BuildID: 20150122002808
Gaia: e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko: 4a90da67661e
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150122010203
Gaia: 917b6c36717fddc6e71ffc1ec249633c8044c93c
Gecko: 34e2d2bd7ec4
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0