1118134 - B2G desktop should be able to draw in the titlebar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Paul Rouget [:paul]]

The same way we can draw in the titlebar in a xul:window with chromemargin="0,-1,-1,-1", it should be possible to draw shell.html over the titlebar.

Comment 1

[Paul Rouget [:paul]]

Attachment: DOMWindowUtils.setChromeMargin()

Comment 2

[Paul Rouget [:paul]]

Attachment: example

Comment 3

[Paul Rouget [:paul]]

Attachment: screenshot

Of course, this is useless until we support dragging from HTML content.

Comment 4

[Paul Rouget [:paul]]

Attachment: v1

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8555662 [details] [diff] [review]
v1

Review of attachment 8555662 [details] [diff] [review]:
-----------------------------------------------------------------

You might need a DOM peer review on the idl change.

::: dom/interfaces/base/nsIDOMWindowUtils.idl
@@ +1769,5 @@
>    readonly attribute unsigned long long framesReflowed;
> +
> +  /**
> +   * Controls the amount of chrome that should be visible on each side of
> +   * the window. Works like the chromemargin xul:window attribute.

Mention that this should only be used if your window is not XUL.

Comment 6

[Paul Rouget [:paul]]

Attachment: v1.1

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8555723 [details] [diff] [review]
v1.1

r=me

Comment 8

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=c60564364789

Comment 9

[Paul Rouget [:paul]]

This throws on Mac. I need to figure out what's going on.

Comment 10

[Paul Rouget [:paul]]

Attachment: addendum

Comment 11

[Markus Stange [:mstange]]

Comment on attachment 8557032 [details] [diff] [review]
addendum

Oops.

Comment 12

[Paul Rouget [:paul]]

Attachment: folded

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58adbd5539d0

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c479a713e4c5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c479a713e4c5