1118164 - Tracelogging: Don't fail if there is no logger

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

"logger" can be a nullptr upon fail.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8544450 [details] [diff] [review]
Patch

Review of attachment 8544450 [details] [diff] [review]:
-----------------------------------------------------------------

I'm okay with this, but in the first place, why would we even create the TLEvent if there's no logger?

Comment 3

[Hannes Verschore [:h4writer]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #2)
> I'm okay with this, but in the first place, why would we even create the
> TLEvent if there's no logger?

The code is:
> js::TraceLoggerEvent event(logger, TraceLogger_AnnotateScripts, options);
> js::AutoTraceLog scriptLogger(logger, event);

To make it easier to read the code we only test for a logger inside AutoTraceLog and TraceLogStartEvent etc. So the event is made unconditionally.

Comment 4

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39b05ad67a2f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39b05ad67a2f